Move JSON schema helpers to json ingestion gem#1201
Open
jwils wants to merge 1 commit into
Open
Conversation
jwils
force-pushed
the
joshuaw/schema-extension-plumbing
branch
from
edb2d90 to
ef7b7e5
Compare
jwils
force-pushed
the
joshuaw/json-ingestion-extension
branch
3 times, most recently
from
7eea290 to
461ba24
Compare
jwils
changed the title
jwils
force-pushed
the
joshuaw/json-ingestion-extension
branch
2 times, most recently
from
64ff2af to
7d4becc
Compare
jwils
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwondrusch and
myronmarston
as code owners
myronmarston
approved these changes
May 22, 2026
Collaborator
There was a problem hiding this comment.
/nit Looks like this is needed to type check due to elasticgraph-json_ingestion/lib/elastic_graph/json_ingestion.rb in #1199 defining this module. If you decide to address https://github.com/block/elasticgraph/pull/1199/changes#r3278668713, can this also be dropped?
|
|
||
| spec.add_dependency "elasticgraph-graphql", ElasticGraph::VERSION # needed since we validate that scalar `coerce_with` options are valid (which loads scalar coercion adapters) | ||
| spec.add_dependency "elasticgraph-indexer", ElasticGraph::VERSION # needed since we validate that scalar `prepare_for_indexing_with` options are valid (which loads indexing preparer adapters) | ||
| spec.add_dependency "elasticgraph-json_ingestion", ElasticGraph::VERSION |
Collaborator
There was a problem hiding this comment.
I'd like elasticgraph-json_ingestion to be an optional extension that is not even installed in EG projects that opt to use proto ingestion for all indexed types.
If the gem is needed in the test suite, can this be add_development_dependency?
jwils
force-pushed
the
joshuaw/schema-extension-plumbing
branch
from
ef7b7e5 to
d841965
Compare
jwils
force-pushed
the
joshuaw/json-ingestion-extension
branch
from
7d4becc to
e64b589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Keep the first extraction layer reviewable by moving the JSON Schema helper files without changing their contents, so GitHub can render them as renames instead of delete/add rewrites.
What
elasticgraph-json_ingestionRisk Assessment
Low to medium - mostly file moves plus require/dependency wiring.
References
git diff -M --summaryreports the moved helper files as 100% renames, includingjson_schema_with_metadata.rb.