Skip to content

Improve admin mapping change output#1206

Open
jwils wants to merge 1 commit into
mainfrom
joshuaw/hide-delete-changes-admin-lambda
Open

Improve admin mapping change output#1206
jwils wants to merge 1 commit into
mainfrom
joshuaw/hide-delete-changes-admin-lambda

Conversation

@jwils
Copy link
Copy Markdown
Collaborator

@jwils jwils commented May 22, 2026

🤖 Updated by my AI agent.

Summary

  • Move mapping-removal noise handling into elasticgraph-admin so all admin users benefit.
  • Preserve current mapping fields in update payloads and diffs, hiding unsupported field removals while still showing new fields and mapping parameter changes.
  • Keep settings diffs complete, and report new index templates as created instead of dumping the full config diff.

Context

Mapping removals are unsupported by Elasticsearch/OpenSearch, so showing removed fields every admin run just makes the diffs harder to read. This addresses #766 and the review feedback to improve elasticgraph-admin directly instead of adding an elasticgraph-admin_lambda opt-in.

Verification

  • script/lint --fix
  • script/spellcheck -w
  • script/type_check
  • bundle exec rspec elasticgraph-admin/spec/unit
  • bundle exec rspec elasticgraph-admin/spec/unit/elastic_graph/admin/index_definition_configurator/mapping_update_spec.rb
  • bundle exec rspec elasticgraph-local/spec/unit
  • script/run_gem_specs elasticgraph-admin_lambda

Datastore-backed specs were attempted locally but blocked because the datastore is not running and this environment has neither docker nor docker-compose available to boot it. GitHub Actions is running those datastore-backed checks.

@jwils jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from 7123aca to 37b0486 Compare May 22, 2026 23:02
Copy link
Copy Markdown
Collaborator

@myronmarston myronmarston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the output of the admin process improved (it's why I opened #766!) but:

  • I don't think it needs to be an opt-in thing. I don't think we've ever found the delete changes to be useful and I doubt anyone else has. It's simpler to just improve it for everyone with no opt-in needed.
  • Can we improve the output in elasticgraph-admin so it improves the output for projects which don't use elasticgraph-admin_lambda?

@jwils jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from 37b0486 to c6e3e1f Compare May 22, 2026 23:43
@jwils jwils changed the title Hide delete changes in admin lambda output Improve admin mapping change output May 22, 2026
@jwils jwils marked this pull request as ready for review May 22, 2026 23:49
@jwils jwils force-pushed the joshuaw/hide-delete-changes-admin-lambda branch from c6e3e1f to a9a165f Compare May 23, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants