Improve admin mapping change output#1206
Open
jwils wants to merge 1 commit into
Open
Conversation
7123aca to
37b0486
Compare
Collaborator
myronmarston
left a comment
There was a problem hiding this comment.
I'd like to see the output of the admin process improved (it's why I opened #766!) but:
- I don't think it needs to be an opt-in thing. I don't think we've ever found the delete changes to be useful and I doubt anyone else has. It's simpler to just improve it for everyone with no opt-in needed.
- Can we improve the output in
elasticgraph-adminso it improves the output for projects which don't useelasticgraph-admin_lambda?
37b0486 to
c6e3e1f
Compare
c6e3e1f to
a9a165f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Updated by my AI agent.
Summary
elasticgraph-adminso all admin users benefit.Context
Mapping removals are unsupported by Elasticsearch/OpenSearch, so showing removed fields every admin run just makes the diffs harder to read. This addresses #766 and the review feedback to improve
elasticgraph-admindirectly instead of adding anelasticgraph-admin_lambdaopt-in.Verification
script/lint --fixscript/spellcheck -wscript/type_checkbundle exec rspec elasticgraph-admin/spec/unitbundle exec rspec elasticgraph-admin/spec/unit/elastic_graph/admin/index_definition_configurator/mapping_update_spec.rbbundle exec rspec elasticgraph-local/spec/unitscript/run_gem_specs elasticgraph-admin_lambdaDatastore-backed specs were attempted locally but blocked because the datastore is not running and this environment has neither
dockernordocker-composeavailable to boot it. GitHub Actions is running those datastore-backed checks.