Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12ab372b08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let Some(goose_session_id) = goose_session_id else { | ||
| return Ok(false); | ||
| }; |
There was a problem hiding this comment.
Honor cancel requests during session preparation
cancel_session_inner bails out when the composite key is not yet present in state.sessions, but that map is populated only after prepare_session_inner finishes creating/loading the Goose session. If a user hits Stop while preparation is still in flight, cancellation returns false and the prompt can still execute server-side (including token/tool work) despite the stop request. Please persist a pending-cancel state before preparation completes, or register the session key earlier so cancellation can be applied immediately.
Useful? React with 👍 / 👎.
scripts/ensure-local-goose.sh
Outdated
| fi | ||
| fi | ||
|
|
||
| read -r branch remote_head <<<"$(resolve_branch)" |
There was a problem hiding this comment.
Stop script when branch resolution fails
resolve_branch is invoked via command substitution in read -r branch remote_head <<<"$(resolve_branch)", so exit inside fail_or_skip only terminates the subshell, not the main script. When branch resolution fails, the script can continue with empty values and fall into later commands (for example git fetch with an empty ref), producing unexpected failures and bypassing the intended fail/skip control flow. Capture the function status explicitly and abort in the caller instead of relying on exit inside command substitution.
Useful? React with 👍 / 👎.
Summary
Move goose2 toward a thinner ACP client by routing session lifecycle through
goose serveinstead of keeping provider/runtime behavior in the Tauri app.What changed
goose serveconnectiongoose serveon demand and bind streamed session events back to the local chat sessiongoosejust setupcan build the integration branch andjust devcan cheaply detect when setup needs to be rerunTesting
cd src-tauri && cargo clippy --all-targets --all-features -- -D warningscd src-tauri && cargo testpnpm checkpnpm typecheckpnpm buildpnpm testcd src-tauri && cargo checkcd src-tauri && cargo clippy -- -D warnings