Skip to content

Add ProtoFleet activity E2E coverage#258

Open
edgars-avotins wants to merge 1 commit into
mainfrom
edgars/fleet-activity-e2e
Open

Add ProtoFleet activity E2E coverage#258
edgars-avotins wants to merge 1 commit into
mainfrom
edgars/fleet-activity-e2e

Conversation

@edgars-avotins
Copy link
Copy Markdown
Contributor

Summary

  • add Activity detail modal coverage for a real Blink LEDs batch action
  • add Activity filter-pill and CSV export coverage
  • add Scope filter coverage using group activity and stable test hooks for Activity pills

Verification

  • ./node_modules/.bin/eslint e2eTests/protoFleet/pages/activity.ts e2eTests/protoFleet/spec/activity.spec.ts src/protoFleet/features/activity/pages/ActivityPage.tsx
  • npx playwright test -c e2eTests/protoFleet/playwright.config.ts e2eTests/protoFleet/spec/activity.spec.ts --project=desktop --no-deps
  • npx playwright test -c e2eTests/protoFleet/playwright.config.ts e2eTests/protoFleet/spec/activity.spec.ts --project=mobile --no-deps

@edgars-avotins edgars-avotins requested a review from a team as a code owner May 19, 2026 11:45
Copilot AI review requested due to automatic review settings May 19, 2026 11:45
@github-actions github-actions Bot added javascript Pull requests that update javascript code client labels May 19, 2026
@github-actions
Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated security-focused code review generated by Codex.
It should be used as a supplementary check alongside human review.
False positives are possible - use your judgment.

Scope summary

  • Reviewed pull request diff only (fcd233c3dcc5ec441c449c2c9276861e82b9cf77...261bb0e0e92efa35d7bb22a4b5dd752624f07f8f, exact PR three-dot diff)
  • Model: gpt-5.5

💡 Click "edited" above to see previous reviews for this PR.


Review Summary

Overall Risk: NONE

Findings

No security, correctness, or reliability findings in the scoped diff.

Notes

Reviewed .git/codex-review.diff only. The PR changes are limited to ProtoFleet Activity E2E page/spec coverage plus adding data-testid/testId selectors to Activity filter pills in ActivityPage.tsx.

No backend, database, auth, gRPC/protobuf, plugin, discovery, infrastructure, Rust, or mining-pool configuration code changed in this diff. I did not run tests; this was a static review of the pinned PR diff.


Generated by Codex Security Review |
Triggered by: @edgars-avotins |
Review workflow run

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands ProtoFleet Activity Playwright E2E coverage by adding scenarios around batch action detail viewing (Blink LEDs), filter pill behavior (type/user/scope), and CSV export—plus a small UI test hook to make pill targeting stable.

Changes:

  • Added stable test hooks for the Activity filter pills container and individual pills.
  • Extended the Activity Playwright page object with scope filtering, pill interactions, detail modal assertions, and CSV export download handling.
  • Added new E2E specs covering Blink LEDs batch detail modal, removable filter pills, CSV export, and group-scope filtering.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
client/src/protoFleet/features/activity/pages/ActivityPage.tsx Adds data-testid for the filter pill container and testId for pill buttons to support stable E2E targeting.
client/e2eTests/protoFleet/pages/activity.ts Adds new Playwright helpers for scope filtering, pill visibility/removal, opening/dismissing detail modal, and exporting CSV.
client/e2eTests/protoFleet/spec/activity.spec.ts Adds new Activity E2E tests for Blink LEDs batch details, filter pill removal, CSV export download, and group scope filtering (with cleanup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants