Add ProtoFleet activity E2E coverage#258
Conversation
🔐 Codex Security Review
Review SummaryOverall Risk: NONE FindingsNo security, correctness, or reliability findings in the scoped diff. NotesReviewed No backend, database, auth, gRPC/protobuf, plugin, discovery, infrastructure, Rust, or mining-pool configuration code changed in this diff. I did not run tests; this was a static review of the pinned PR diff. Generated by Codex Security Review | |
There was a problem hiding this comment.
Pull request overview
This PR expands ProtoFleet Activity Playwright E2E coverage by adding scenarios around batch action detail viewing (Blink LEDs), filter pill behavior (type/user/scope), and CSV export—plus a small UI test hook to make pill targeting stable.
Changes:
- Added stable test hooks for the Activity filter pills container and individual pills.
- Extended the Activity Playwright page object with scope filtering, pill interactions, detail modal assertions, and CSV export download handling.
- Added new E2E specs covering Blink LEDs batch detail modal, removable filter pills, CSV export, and group-scope filtering.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/src/protoFleet/features/activity/pages/ActivityPage.tsx | Adds data-testid for the filter pill container and testId for pill buttons to support stable E2E targeting. |
| client/e2eTests/protoFleet/pages/activity.ts | Adds new Playwright helpers for scope filtering, pill visibility/removal, opening/dismissing detail modal, and exporting CSV. |
| client/e2eTests/protoFleet/spec/activity.spec.ts | Adds new Activity E2E tests for Blink LEDs batch details, filter pill removal, CSV export download, and group scope filtering (with cleanup). |
Summary
Verification