fix: memory leak during key generation #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed --ssz flag to be default=True - Added --no-ssz flag to use bincode/JSON encoding - Updated README to reflect SSZ as default - Users can now run: python3 benchmark/benchmark.py (uses SSZ) - Or: python3 benchmark/benchmark.py --no-ssz (uses bincode)
- Removed --ssz and --no-ssz flags (SSZ is now always used) - Removed all bincode/JSON file handling code - Simplified all function signatures (removed use_ssz parameters) - Updated README to remove bincode references - SSZ is now the only supported encoding for cross-language tests All cross-language tests pass for 2^8, 2^18, and 2^32 with SSZ.
- Updated step name to clarify it runs SSZ compatibility tests - Removed --ssz flag since SSZ is now the only encoding
- Added --ssz flag back as deprecated (ignored) - Marked as 'Kept for backward compatibility' - Scripts using --ssz will continue to work without errors - SSZ is always used regardless of flag
- Removed the performance-benchmark-2-32 job - This was time-consuming (30 min timeout) and not needed for every push - Performance benchmarks can be run locally when needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.