chore: Code cleanup #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 2^8 lifetime, always regenerate from seed instead of loading SSZ keys. This avoids epoch configuration mismatches between keygen and sign steps. The issue: 2^8 keygen uses 2 active epochs (2*128=256), but the SSZ file from a previous run might have different active epochs, causing verification to fail. Solution: Skip SSZ loading for 2^8 and always use seed-based regeneration. This ensures keygen -> sign flow works correctly in CI. 2^18 and 2^32 continue to use pre-generated keys when available. All tests pass: - benchmark.py for 2^8, 2^18, 2^32 - inspect_pregenerated_keys.py (uses 2^32 keys)
- Remove lengthy reasoning comments (e.g., 'But wait', 'Actually, I think') - Simplify 'CRITICAL' and 'CRITICAL DEBUG' comments to concise statements - Remove verbose RNG state matching explanations in cross_lang_zig_tool.zig - Preserve essential technical documentation - No functional changes, all tests passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.