Draft
Conversation
jobh
force-pushed
the
jobh/petsc-solver
branch
from
119a746 to
4a6b2a3
Compare
Collaborator
|
@jobh is there some demo already where PETSc Nest/solvers could be tried? |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 396861d |
Collaborator
Author
|
@MiroK I don't know, there is maybe something in the petsc4py distribution? The new demo |
jobh
force-pushed
the
jobh/petsc-isolated-options
branch
from
693396e to
f6354f4
Compare
jobh
force-pushed
the
jobh/petsc-solver
branch
from
66d2349 to
c70fb1b
Compare
jobh
force-pushed
the
jobh/petsc-isolated-options
branch
from
f6354f4 to
deb6dd5
Compare
jobh
force-pushed
the
jobh/petsc-solver
branch
from
c70fb1b to
ad27b0f
Compare
jobh
force-pushed
the
jobh/petsc-isolated-options
branch
from
deb6dd5 to
56befcb
Compare
jobh
force-pushed
the
jobh/petsc-solver
branch
from
ad27b0f to
f494664
Compare
jobh
force-pushed
the
jobh/petsc-isolated-options
branch
from
56befcb to
508c80d
Compare
jobh
force-pushed
the
jobh/petsc-solver
branch
from
f494664 to
e65c6aa
Compare
jobh
force-pushed
the
jobh/petsc-solver
branch
from
e65c6aa to
7c2e4c5
Compare
MiroK
reviewed
Feb 21, 2023
| except: | ||
| info('failed to set near null space (not supported in petsc4py version)') | ||
|
|
||
| class petsc_base(block_base): |
Collaborator
There was a problem hiding this comment.
Some of the methods, e.g. LU, Cholesky miss the prefix argument in their __init__ signature.
Collaborator
Author
There was a problem hiding this comment.
I think it must be a problem introduced in PR #9, not this one? I'll look into it.
Collaborator
Author
There was a problem hiding this comment.
Rebased on top of bugfix
jobh
force-pushed
the
jobh/petsc-solver
branch
from
7c2e4c5 to
396861d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype interface with PETSc solvers.
Unfortunately, I could not get it to work with PETSc's
VecNestvectors, which means that we need to copy vectors back and forth all the time. I'm not planning to merge this unless anyone knows PETSc well enough to figure out theVecNestproblem.