Require creating default consumer atomically#5637
Draft
morgando wants to merge 2 commits intobloomberg:mainfrom
Draft
Require creating default consumer atomically#5637morgando wants to merge 2 commits intobloomberg:mainfrom
morgando wants to merge 2 commits intobloomberg:mainfrom
Conversation
Signed-off-by: Morgan Douglas <mdouglas47@bloomberg.net>
Signed-off-by: Morgan Douglas <mdouglas47@bloomberg.net>
roborivers
approved these changes
Dec 19, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
logfill_logput_window_generated
comdb2sys_pagesize_generated
reco-ddlk-sql
insert_lots_ssl_generated
insert_lots
guid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires that default consumers be created atomically.
Depends on #5636 - we need that merged first since the atomic path depends on protobuf. So to only support the atomic path, protobuf needs to be non-optional.