-
Notifications
You must be signed in to change notification settings - Fork 232
Assert no schemalk during distributed commit #5680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
db55293 to
b7b5988
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 18/639 tests failed ⚠.
The first 10 failing tests are:
queuedb_multimeta [core dumped]
rowlock_update [core dumped]
queuedb_locks [core dumped]
consumer_snapshot_generated [core dumped]
consumer [core dumped]
vutf8_rowlocks [core dumped]
vutf8_rowlocks_off_osql_odh_blob_generated [core dumped]
sql [core dumped]
trigger_lock_inversion [core dumped]
truncatesc_offline_generated
456aea0 to
c94856a
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
queuedb_rollover
reco-ddlk-sql
eefda31 to
4b5518e
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
57d41e7 to
1bdc40a
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 7/639 tests failed ⚠.
The first 10 failing tests are:
logfill
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
tunables
sc_downgrade
insert_lots_ssl_generated
insert_lots
0039838 to
8aca793
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 7/639 tests failed ⚠.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
tunables
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
2e0086c to
fd2e7a1
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/639 tests failed ⚠.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql
fd2e7a1 to
2fbf24e
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/639 tests failed ⚠.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
insert_lots
sc_truncate_multiddl_generated
reco-ddlk-sql
5c2d8aa to
f98ab7c
Compare
96cbe62 to
63fbba1
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated
sc_resume
silogdel
triggersc_latency
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
reco-ddlk-sql
7a11d08 to
c5013d7
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_timepart [core dumped]
silogdel
consumer_non_atomic_default_consumer_generated
sc_downgrade
reco-ddlk-sql
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
098b95b to
b0f5e59
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
|
/plugin-branch assert_no_schemalk_plugins |
65a91f7 to
a5a0bdc
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
silogdel
reco-ddlk-sql
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
phys_rep_tiered_firstfile_generated
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
a5a0bdc to
695beec
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
incremental_backup_usenames
silogdel
reco-ddlk-sql
analyze
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
lock_views
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
silogdel [core dumped]
sc_truncate_lockorder_generated
consumer
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
truncatesc_offline_generated
reco-ddlk-sql
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
silogdel [core dumped]
sc_timepart
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
reco-ddlk-sql
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
silogdel [core dumped]
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql
695beec to
d839075
Compare
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
d839075 to
ad0a7e2
Compare
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
silogdel [core dumped]
truncoplog_timebased_generated
truncoplog_noprotobuf_generated
tmptbl_leak_zeropool_generated
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
sc_downgrade
truncatesc_offline_generated
This PR cleans up cases where we call distributed-commit unnecessarily.