Skip to content

Add identity_fork test #5689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mohitkhullar merged 1 commit into from
Jan 30, 2026
Merged

Add identity_fork test #5689

mohitkhullar merged 1 commit into from
Jan 30, 2026
+152 −0

Conversation

@mohitkhullar
Copy link
Contributor

@mohitkhullar mohitkhullar commented Jan 23, 2026

No description provided.

roborivers
roborivers suggested changes Jan 23, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

roborivers
roborivers suggested changes Jan 24, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 7/640 tests failed ⚠.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
identity_fork
tunables
sc_downgrade
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots

roborivers
roborivers suggested changes Jan 27, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
identity_fork
disttxn
insert_lots_ssl_generated
insert_lots
incoh_remsql_rte_connect_generated
incoh_remsql

roborivers
roborivers suggested changes Jan 27, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
protobuf_connectmsg_mix [setup failure]
consumer_non_atomic_default_consumer_generated
identity_fork
insert_lots_ssl_generated
analyze_fastinit_race
reco-ddlk-sql
incoh_remsql_rte_connect_generated
incoh_remsql

@mohitkhullar mohitkhullar force-pushed the identity_fork_test branch 4 times, most recently from 3084f0c to 1ffb050 Compare January 28, 2026 15:52
roborivers
roborivers suggested changes Jan 28, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
reco-ddlk-sql
consumer_non_atomic_default_consumer_generated
identity_fork
insert_lots_ssl_generated
insert_lots

roborivers
roborivers suggested changes Jan 28, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
identity_fork

@mohitkhullar mohitkhullar marked this pull request as draft January 29, 2026 18:56
@mohitkhullar
Add identity_fork test
85c3e15 
Signed-off-by: mkhullar <mohit.khullar@gmail.com>
roborivers
roborivers suggested changes Jan 29, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
insert_lots
consumer_non_atomic_default_consumer_generated
insert_lots_ssl_generated
sc_truncate_multiddl_generated
reco-ddlk-sql

@mohitkhullar mohitkhullar marked this pull request as ready for review January 30, 2026 13:06
@mohitkhullar
Copy link
Contributor Author

mohitkhullar commented Jan 30, 2026

Thanks

@mohitkhullar mohitkhullar merged commit 92604d0 into bloomberg:main Jan 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mponomar mponomar mponomar approved these changes

+1 more reviewer

@roborivers roborivers roborivers requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohitkhullar @mponomar @roborivers