Skip to content

Conversation

@chands10
Copy link
Contributor

To help us review your pull request, please consider providing an overview of the following:

  • What is the type of the change (bug fix, feature, documentation and etc.) ?
  • What are the current behavior and expected behavior, if this is a bugfix ?
  • What are the steps required to reproduce the bug, if this is a bugfix ?
  • What is the current behavior and new behavior, if this is a feature change or enhancement ?
  • [Optional] Why is the new behavior better than the current behavior, if this is a feature change ?

Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
insert_lots
consumer_non_atomic_default_consumer_generated
skipscan
sc_downgrade
insert_lots_ssl_generated
reco-ddlk-sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
logarchive [setup failure]
queuedb_rollover_noroll1_generated
consumer_non_atomic_default_consumer_generated
phys_rep_tiered_firstfile_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
incoh_remsql_rte_connect_generated
incoh_remsql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_timepart [core dumped]
insert_lots
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
pmux_sqlite_memory_generated
pmux_sqlite_file_generated
truncatesc_offline_generated
insert_lots_ssl_generated
reco-ddlk-sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants