Fix broken analyze for aliased tables #5703
Conversation
…rds during backup. Also, preserve aliased shard 0 analyze, i.e. if we run "analyze $0_..." do not convert that to "analyze <partition_name>" Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Thank you for your pull request!
It appears that you have not provided a description. To help us review your pull request, please consider providing an overview of the following:
-
What is the type of the change (bugfix, feature, documentation and etc.)
-
What are the current behavior and expected behavior, if this is a bugfix
-
What are the steps to reproduce the bug, if this is a bugfix
-
What are the current behavior and new behavior, if this is a feature change
-
Why is the new behavior better than the current behavior, if this is a feature change
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
truncatesc_offline_generated [core dumped]
insert_lots_ssl_generated
reco-ddlk-sql
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
insert_lots
2 participants
This affects time partitions created on existing tables; the initial analyze works; the follow-up fails because code tries to delete same rows twice by calling backup for stats for both tablename and sqlaliasname.
Also, preserve aliased shard 0 analyze, i.e. if we run "analyze $0_..." do not convert that to "analyze <partition_name>"