🛡️ Sentinel: Allow configurable Cipher Suite#11
🛡️ Sentinel: Allow configurable Cipher Suite#11google-labs-jules[bot] wants to merge 1 commit intomasterfrom
Conversation
… var - Replaced hardcoded 'DHE-RSA-AES256-SHA' cipher suite with configurable 'CIPHER_SUITES' variable - Set default 'CIPHER_SUITES' to 'DHE-RSA-AES256-SHA' to maintain backward compatibility - Documented the change in .jules/sentinel.md This allows users to upgrade to stronger ciphers like AES256-GCM-SHA384 without rebuilding the image.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
🛡️ Sentinel: Allow configurable Cipher Suite
Vulnerability: The
entrypoint.shscript hardcodedDHE-RSA-AES256-SHAas the only allowed cipher suite.Impact: Users were unable to use modern, stronger ciphers (e.g., AES-GCM) supported by newer SoftEther versions and TLS 1.2+ clients.
Fix: Introduced
CIPHER_SUITESenvironment variable with a default ofDHE-RSA-AES256-SHA. This allows overriding the cipher suite at runtime.Verification: Reviewed
entrypoint.shlogic to ensure the variable is used and defaults correctly. Verified script syntax withbash -n.PR created automatically by Jules for task 14272976687347461831 started by @bluPhy