feat(mounts): Implement mounts option for Recipe and Module#716
feat(mounts): Implement mounts option for Recipe and Module#716Aex12 wants to merge 9 commits intoblue-build:mainfrom
Conversation
b43e9a5 to
ff840e2
Compare
ff840e2 to
f84e1e9
Compare
gmpinder
left a comment
There was a problem hiding this comment.
Looking good so far can you add some of this new functionality to the recipe in ./integration-test/test-repo/? That one is one that gets built in the integration tests. The one you were updating, which was needed, is for testing the schema.
|
I also left a comment in discord about updating the constant for the schema base URL. Doing that will pull the new schema changes before they get fully merged in. |
|
Hi @gmpinder, I just updated the integration tests and the schema base url constant |
|
Hi @gmpinder I just updated all the other recipes in the integration tests to include the cache mount option so that the test defined in common.yml wont fail for those tests. This should fix the integration tests not passing. |
|
I'm seeing the error message |
|
@Aex12 are you planning on finishing this, or do you need me to take it over the finish line? |
Hi @gmpinder, sorry I had to take care of some personal matters and didn't have a chance to get back to this PR. I can finish it now. About this error you mentioned earlier:
Seems like OCI builds dont support the field We have two options, we either disallow the "sharing" field entirely for the mount What do you think? I think disabling it entirely is the most appropiate choice to achieve consistency accross different build engines, but you decide. |
It's all good, I completely understand that.
I'll have to get back to you on that. I'm going to do some investigating, though it might take a bit because my life is also fairly hectic at the moment. |
This PR implements the
mountsoption as proposed in blue-build/schema#16