Skip to content

frontend: kraken: only show extension logs when it is enabled#3824

Merged
patrickelectric merged 1 commit intobluerobotics:masterfrom
nicoschmdt:dont-show-logs-disabled
Mar 12, 2026
Merged

frontend: kraken: only show extension logs when it is enabled#3824
patrickelectric merged 1 commit intobluerobotics:masterfrom
nicoschmdt:dont-show-logs-disabled

Conversation

@nicoschmdt
Copy link
Contributor

@nicoschmdt nicoschmdt commented Mar 12, 2026

the verification on the backend will be added with #3803

Summary by Sourcery

Bug Fixes:

  • Hide the extension log viewing button for disabled extensions to prevent showing logs when the extension is not enabled.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 12, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Gate the "Show Logs" button for installed Kraken extensions so it only appears when an extension is enabled, preventing log viewing for disabled extensions.

File-Level Changes

Change Details Files
Conditionally render the Show Logs button for extensions based on their enabled state.
  • Add a v-if guard to the Show Logs button so it is only rendered when the associated extension is enabled
  • Keep existing styling and click event emission for the Show Logs button unchanged
core/frontend/src/components/kraken/cards/InstalledExtensionCard.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric patrickelectric merged commit a3c1939 into bluerobotics:master Mar 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants