Merged
Conversation
The notecard-binary-test job requires secrets (Tailscale OAuth, Notehub credentials, ngrok auth) that are not available to pull requests from forks, causing guaranteed failures. Skip the job on fork PRs while still running it for same-repo PRs, scheduled runs, and manual workflow dispatches.
m-mcgowan
force-pushed
the
ci/skip-hil-on-forks
branch
from
0da6424 to
7ab1e60
Compare
Updated condition to skip notecard-binary-test on fork PRs and nightly builds.
zfields
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notecard-binary-testjob on pull requests from forks, where secrets (Tailscale OAuth, Notehub credentials, ngrok auth token) are unavailableProblem
Fork PRs always fail the HIL test because GitHub does not expose repository secrets to workflows triggered by fork PRs. The job fails immediately at the "Connect to Tailscale" step with
OAuth identity empty.Fix
Add a condition to the
notecard-binary-testjob:The job still runs for:
Test plan