Skip to content

Add ByteIpAddr type serialize to byte representation#4

Closed
canoriz wants to merge 1 commit intobluk:trunkfrom
canoriz:ipaddr
Closed

Add ByteIpAddr type serialize to byte representation#4
canoriz wants to merge 1 commit intobluk:trunkfrom
canoriz:ipaddr

Conversation

@canoriz
Copy link
Copy Markdown

@canoriz canoriz commented Jul 13, 2025

In BitTorrent BEP10, extend handshake sends IPv6/IPv4 address in a "compact form", which is the big-endian byte representation, represented by byte string length of 4(ipv4)/16(ipv6). This commit adds a ByteIpAddr type to serialize and deserialize between core::IpAddr and byte string representation.

@canoriz canoriz changed the title add IpAddr type serailize to byte representation Add ByteIpAddr type serialize to byte representation Jul 13, 2025
@canoriz
Copy link
Copy Markdown
Author

canoriz commented Apr 4, 2026

I fixed the build error when enable alloc and disable std feature.

@bluk
Copy link
Copy Markdown
Owner

bluk commented Apr 7, 2026

Thanks for the PR. The implementation seems fine and would be useful, but this functionality is better suited for a common BitTorrent library. There is nothing specific in the implementation requiring this bt_bencode library and in case you switch to a different bencode Serde based library, you could still re-use this type without pulling in this crate.

@bluk bluk closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants