Conversation
phiwuu
requested changes
Apr 2, 2026
| trlc_obj = getattr(node, "trlc_obj", None) | ||
|
|
||
| if trlc_obj: | ||
| description = trlc_obj.to_python_dict().get("description") |
Member
There was a problem hiding this comment.
This is a hard-coded project-specific detail. There is no guarantee all users of TRLC will call their attribute "description". We need a flexible and configurable solution here.
Contributor
Author
There was a problem hiding this comment.
Ok, I guess we need to have some more detailed discussion for a concept. Can we maybe merge it now as it is and create a follow up issue for it?
hoe-jo
force-pushed
the
joho_add_trlc_renderer
branch
from
b1d13c6 to
e862c41
Compare
hoe-jo
force-pushed
the
joho_add_trlc_renderer
branch
2 times, most recently
from
8979f91 to
72eb23d
Compare
phiwuu
approved these changes
Apr 14, 2026
phiwuu
force-pushed
the
joho_add_trlc_renderer
branch
from
72eb23d to
338e54d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.