Skip to content

⚡ Bolt: Parallelize ZimaOSV1ModelEntries fetch #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobdivx wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

⚡ Bolt: Parallelize ZimaOSV1ModelEntries fetch #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-06-25 - Parallelizing State-Dependent Array Fetches
**Learning:** Sequential network calls inside a loop (`for...of`) create cumulative latency, especially when collecting configuration items across multiple potential reverse proxy paths. It's safe to parallelize these requests if the state side-effects (e.g., updating `lastStatus`, `lastError`, `lastRaw`) depend strictly on the sequence order.
**Action:** Replace sequential loops with `await Promise.all(paths.map(fetchFn))`. Then, iterate through the resolved results array (`for (const r of results)`) to process side effects. This guarantees order-dependent logic remains identical while shifting the I/O bottleneck from serial to parallel execution.
7 changes: 5 additions & 2 deletions src/lib/forge-openai-surface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,11 @@ export async function collectZimaOSV1ModelEntries(
let lastError: string | undefined;
let lastRaw: unknown = null;

for (const path of V1_MODELS_PATHS) {
const r = await fetchZimaOSJson(email, path);
const results = await Promise.all(
V1_MODELS_PATHS.map(path => fetchZimaOSJson(email, path))
);

for (const r of results) {
lastStatus = r.status;
lastError = r.error;
lastRaw = r.data;
Expand Down