Skip to content

🎨 Palette: [UX improvement] Add ARIA labels to icon-only buttons for accessibility #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobdivx wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

🎨 Palette: [UX improvement] Add ARIA labels to icon-only buttons for accessibility #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/agents/AgentCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ export default function AgentCard({
disabled={commandBusy}
class={`rounded-xl border p-2 transition-all disabled:opacity-50 ${cmd === 'start_work' ? 'bg-gray-900 border-gray-900 text-white hover:bg-black' : 'bg-white border-gray-200 text-gray-400 hover:text-rose-500 hover:border-rose-200'}`}
title={cmd === 'start_work' ? 'Lancer une mission' : 'Arrêter'}
aria-label={cmd === 'start_work' ? 'Lancer une mission' : 'Arrêter'}
>
{cmd === 'start_work' ? (
<svg class="w-3.5 h-3.5" fill="none" viewBox="0 0 24 24" stroke="currentColor"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2.5" d="M14.752 11.168l-3.197-2.132A1 1 0 0010 9.87v4.263a1 1 0 001.555.832l3.197-2.132a1 1 0 000-1.664z" /></svg>
Expand All @@ -241,6 +242,7 @@ export default function AgentCard({
}}
class="rounded-xl border border-gray-200 bg-white p-2 text-gray-400 transition-all hover:border-[#175B37]/30 hover:text-[#175B37]"
title="Configurer cet agent (outils, prompt)"
aria-label="Configurer cet agent"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The aria-label should match the title attribute to ensure that screen reader users receive the same descriptive information as sighted users. The current label omits the context about what can be configured (tools, prompt).

Suggested change
aria-label="Configurer cet agent"
aria-label="Configurer cet agent (outils, prompt)"

>
<svg class="h-3.5 w-3.5" fill="none" viewBox="0 0 24 24" stroke="currentColor">
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M10.325 4.317c.426-1.756 2.924-1.756 3.35 0a1.724 1.724 0 002.573 1.066c1.543-.94 3.31.826 2.37 2.37a1.724 1.724 0 001.065 2.572c1.756.426 1.756 2.924 0 3.35a1.724 1.724 0 00-1.066 2.573c.94 1.543-.826 3.31-2.37 2.37a1.724 1.724 0 00-2.572 1.065c-.426 1.756-2.924 1.756-3.35 0a1.724 1.724 0 00-2.573-1.066c-1.543.94-3.31-.826-2.37-2.37a1.724 1.724 0 00-1.065-2.572c-1.756-.426-1.756-2.924 0-3.35a1.724 1.724 0 001.066-2.573c-.94-1.543.826-3.31 2.37-2.37.996.608 2.296.07 2.572-1.065z" />
Expand Down
2 changes: 2 additions & 0 deletions src/components/agents/AgentRepl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ export default function AgentRepl() {
<button
type="button"
title="Effacer"
aria-label="Effacer"
class="w-3 h-3 rounded-full bg-gray-300 hover:bg-rose-400 transition-colors border border-gray-200"
onClick={(e) => {
e.stopPropagation();
Expand Down Expand Up @@ -262,6 +263,7 @@ export default function AgentRepl() {
class="shrink-0 p-2 rounded-full border border-transparent transition-colors disabled:opacity-25 hover:bg-white hover:border-gray-200 hover:shadow-sm"
style={{ color: FORGE }}
title="Exécuter (Entrée)"
aria-label="Exécuter"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The aria-label should include the keyboard shortcut information present in the title attribute. This helps screen reader users discover that the action can be triggered with the Enter key.

Suggested change
aria-label="Exécuter"
aria-label="Exécuter (Entrée)"

>
<svg class="w-4 h-4" fill="none" viewBox="0 0 24 24" stroke="currentColor">
<path
Expand Down