Upgrade ESLint & Prettier, pin JS dependencies#3711
Merged
bobvandevijver merged 8 commits into6.2from Apr 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the JS tooling stack (ESLint + Prettier) and pins runtime dependencies to stabilize installs, as preparation for the upcoming Vue 3 upgrade.
Changes:
- Pin
dependenciesto exact versions and bump Vue 2 to latest patch. - Migrate ESLint to flat config (
eslint.config.mjs) and update lint/prettier scripts. - Apply formatting/compatibility edits across Vue/JS source (slot syntax, style attribute formatting, etc.).
Reviewed changes
Copilot reviewed 19 out of 26 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Pins runtime deps, bumps Vue, updates ESLint/Prettier toolchain and npm scripts. |
| package-lock.json | Lockfile refresh for upgraded/pinned dependencies and tooling. |
| eslint.config.mjs | New ESLint v9 flat config with Vue + Prettier + Cypress integration. |
| assets/js/app/toolbar/Components/Toolbar.vue | Prettier-driven HTML/style formatting change. |
| assets/js/app/save-on-ctrl-s.js | Prettier-driven function spacing formatting. |
| assets/js/app/patience-is-a-virtue.js | Prettier-driven function spacing formatting. |
| assets/js/app/notifications/index.js | Prettier-driven function spacing formatting. |
| assets/js/app/login/index.js | Renames global component registrations. |
| assets/js/app/listing/Components/Table/Row/index.vue | Prettier-driven inline style formatting. |
| assets/js/app/listing/Components/Table/Row/_Actions.vue | Prettier-driven inline style formatting. |
| assets/js/app/listing/Components/SelectBox.vue | Migrates deprecated slot syntax to v-slot shorthand. |
| assets/js/app/editor/index.js | Renames globally registered editor components. |
| assets/js/app/editor/Components/Select.vue | Slot syntax updates and minor formatting. |
| assets/js/app/editor/Components/Password.vue | Prettier-driven function spacing formatting. |
| assets/js/app/editor/Components/Language.vue | Slot syntax updates. |
| assets/js/app/editor/Components/Imagelist.vue | Changes child event listener names to kebab-case; other formatting. |
| assets/js/app/editor/Components/Image.vue | Adds emits declaration and formatting tweaks. |
| assets/js/app/editor/Components/Filelist.vue | Changes child event listener names to kebab-case; other formatting. |
| assets/js/app/editor/Components/File.vue | Adds emits declaration and formatting tweaks. |
| assets/js/app/editor/Components/Embed.vue | Prettier-driven function spacing formatting. |
| assets/js/app/editor/Components/Date.vue | Removes required: true from a prop that already has a default. |
| assets/js/app/editor/Components/Collection.vue | Uses <component :is> syntax and formatting updates. |
| assets/js/app/common.js | Prettier-driven function spacing + minor chaining formatting. |
| assets/js/app/ajax-save.js | Prettier-driven function spacing formatting. |
| .prettierrc | Updates Prettier options and ordering. |
| .eslintrc.js | Removes legacy ESLint config (replaced by flat config). |
Comments suppressed due to low confidence (1)
assets/js/app/editor/Components/File.vue:180
- This component emits
moveFileUp/moveFileDown(camelCase) but parent templates in this PR were changed to listen formove-file-up/move-file-down. These names won't match, so the handlers won't run. Align emitted event names and template listeners (prefer kebab-case).
emits: ['moveFileUp', 'moveFileDown', 'remove'],
data() {
return {
isDragging: false,
dragCount: 0,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0781875 to
0377e18
Compare
Copilot stopped work on behalf of
bobvandevijver due to an error
April 26, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades ESLint and Prettier to more recent versions, update their configuration and fix newly found issues. This in preparation of the Vue 3 upgrade.
Also bumps Vue 2 to latest, and pin the dependencies so unwanted upgrades are not made by mistake.