Do not inject typeinfo into std namespace#307
Do not inject typeinfo into std namespace#307Kojoley wants to merge 1 commit intoboostorg:developfrom
typeinfo into std namespace#307Conversation
`BOOST_NO_STD_TYPEINFO` should be used to detect if there is no `typeinfo` in `std` namespace, or Boost.Core/Boost.TypeInfo wrappers for a portable solution.
| #if defined(BOOST_NO_STD_TYPEINFO) && defined(__cplusplus) | ||
| #include <typeinfo> | ||
| namespace std{ using ::type_info; } | ||
| #endif |
There was a problem hiding this comment.
I have to manually delete this block of code to get Boost.Config to compile with the IAR compiler, so I hope this PR gets merged soon!
There was a problem hiding this comment.
As I mentioned on the issue tracker, I'm not sure removing these lines is the best solution after all.
There was a problem hiding this comment.
This was an MSVC-specific workaround as I recall, if I restrict the code to MSVC does that help?
BTW is there really no typeinfo? What else is missing?
There was a problem hiding this comment.
Really and truly. Granted, this is because I have disabled exceptions and RTTI on this compiler because our target is embedded. So for example I have BOOST_NO_EXCEPTIONS, BOOST_NO_RTTI and BOOST_NO_TYPEID defined in the preprocessor, and that solves most anticipated problems.
|
@Kojoley I think you need to resolve the merge conflicts for this to ever have a hope of being merged. |
|
The change it conflicts with (035c096) is just wrong and should be reverted, then this will land cleanly. |
|
The problem I have is that this PR breaks the original purpose of those workarounds. Try this: 46e0a13 |
|
What is |
3 participants
BOOST_NO_STD_TYPEINFOshould be used to detect if there is notypeinfoinstdnamespace, or Boost.Core/Boost.TypeInfo wrappers for a portable solution.Closes #306.