Skip to content

Fix scalar division for Octonions and add testing#1375

Merged
mborland merged 2 commits intodevelopfrom
1374
Mar 9, 2026
Merged

Fix scalar division for Octonions and add testing#1375
mborland merged 2 commits intodevelopfrom
1374

Conversation

@mborland
Copy link
Member

@mborland mborland commented Mar 9, 2026

Closes: #1374

@mborland mborland added the bug label Mar 9, 2026
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.34%. Comparing base (e6fb7d3) to head (0074609).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1375   +/-   ##
========================================
  Coverage    95.34%   95.34%           
========================================
  Files          825      825           
  Lines        68160    68160           
========================================
+ Hits         64986    64987    +1     
+ Misses        3174     3173    -1     
Files with missing lines Coverage Δ
include/boost/math/octonion.hpp 70.76% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6fb7d3...0074609. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland mborland merged commit 41b70c2 into develop Mar 9, 2026
66 checks passed
@mborland mborland deleted the 1374 branch March 9, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Octonion Division Broken

1 participant