Conversation
Member
Author
|
Everything looks good using the Boost CMake standard install and subdir tests. Once in I can add a note in the Boost CMake library specific configuration variables section that. Are you good with this change @jzmaddock? All the new behavior is behind the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much like vcpkg has in their patch file, the user needs to define
BOOST_MATH_BUILD_WITH_LEGACY_FUNCTIONSto have these files generated. This allows the current install behavior to be retained, and also allows a user to install all 6 of the C99/TR1 targets if they so choose. Compiled targets require Boost.Config so if we changed the default behavior to build all of these targets, it would require all the header only users to define a macro to stop such an action instead.Closes: #1329