Revert "Make sure we free the Boost.MPI type built for C++ bool" #171
Open
aumuell wants to merge 1 commit intoboostorg:developfrom
Open
Revert "Make sure we free the Boost.MPI type built for C++ bool" #171aumuell wants to merge 1 commit intoboostorg:developfrom
aumuell wants to merge 1 commit intoboostorg:developfrom
Conversation
… there is no MPI Bool type)" This reverts commit c5270b0. Since boostorg#163 "Associate primitive bool type with MPI_CXX_BOOL and make it a logical… " was merged, a dedicated data type for MPI Bool is no longer registered. So it should no longer be freed, either. Otherwise, crashes would occur during MPI_Finalize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... "(sice there is no MPI Bool type)"
This reverts commit c5270b0.
Since #163 "Associate primitive bool type with MPI_CXX_BOOL and make it a logical… " was merged, a dedicated data type for MPI Bool is no longer registered. So it should no longer be freed, either. Otherwise, crashes would occur during MPI_Finalize.