Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to remove kernel arguments during installation via a new --karg-delete CLI option and a corresponding karg-deletes field in the installation configuration. The implementation includes logic to process these deletions before applying new arguments, a helper function for precise or key-based removal, and comprehensive unit and integration tests to verify the functionality. I have no feedback to provide.
|
I wasn't sure about a few things when implementing this.
|
22c5fa8 to
8cb46ce
Compare
This adds `--karg-delete` to install. In some relatively rare use cases, one might want to remove a kernel argument shipped in the container image. Fixes: bootc-dev#1229 Signed-off-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Terence Lee <hone02@gmail.com>
ccccf8a to
ddbbb3f
Compare
|
For my tmt test, I used |
…plemented for composefs Signed-off-by: Terence Lee <hone02@gmail.com>
35c3e5d to
87f13a7
Compare
|
Hi @hone, please skip Packit s390x rpm build issue. The build is successful, but status can't be updated in PR. I already ask for help in Packit channel. |
Following up from the contribfest session. This adds
--karg-deleteto install.In some relatively rare use cases, one might want to remove a kernel argument shipped in the container image.
Fixes: #1229