Skip to content

test: skip OSCI gating AVC test#2106

Open
henrywang wants to merge 1 commit intobootc-dev:mainfrom
henrywang:skip-avc
Open

test: skip OSCI gating AVC test#2106
henrywang wants to merge 1 commit intobootc-dev:mainfrom
henrywang:skip-avc

Conversation

@henrywang
Copy link
Copy Markdown
Collaborator

Skip in TMT test to avoid duplicate with downstream

@bootc-bot bootc-bot bot requested a review from jmarrero March 30, 2026 02:14
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the AVC_ERROR environment variable from the integration plan and adds an AVC check configuration to the tests file to handle expected SELinux denials. A critical review comment points out that the tests file is auto-generated and should not be edited directly; the changes must instead be implemented within the generator script to prevent them from being overwritten.

@henrywang henrywang changed the title test: skip OSCI gating AVC test [WIP] test: skip OSCI gating AVC test Mar 30, 2026
@cgwalters
Copy link
Copy Markdown
Collaborator

The test failures here are really strange, I don't understand how this PR could have triggered them. Unless there's some kind of race somehow, like we installed with an older image?

@henrywang henrywang force-pushed the skip-avc branch 2 times, most recently from 7516195 to 7f91a8d Compare April 1, 2026 09:54
@henrywang henrywang changed the title [WIP] test: skip OSCI gating AVC test test: skip OSCI gating AVC test Apr 1, 2026
@henrywang
Copy link
Copy Markdown
Collaborator Author

henrywang commented Apr 1, 2026

The test failures here are really strange, I don't understand how this PR could have triggered them. Unless there's some kind of race somehow, like we installed with an older image?

The failure is in the prepare phase - tmt's essential-requires step is trying to install audit, policycoreutils on the VM. These are dependencies of the check: how: avc plugin.

Tricky thing is even though the check is enabled: false, tmt still installs the plugin's essential requirements.

Skip in TMT test to avoid duplicate with downstream

Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants