cli: Initialize bootc storage before upgrade --check#2118
Open
cgwalters wants to merge 1 commit intobootc-dev:mainfrom
Open
cli: Initialize bootc storage before upgrade --check#2118cgwalters wants to merge 1 commit intobootc-dev:mainfrom
cgwalters wants to merge 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the upgrade function in crates/lib/src/cli.rs by moving the initialization of the bootc storage directory and the detection of unified storage usage earlier in the process. This ensures that the storage is correctly initialized for both the --check path and the standard upgrade path. I have no feedback to provide as there were no review comments.
jeckersb
previously approved these changes
Apr 2, 2026
Collaborator
jeckersb
left a comment
jeckersb
left a comment
There was a problem hiding this comment.
Tangential to this, it occurs that none of the mtime-triggered stuff like rhsm fact generation works correctly for the composefs backend. I'll file an issue for that.
We had a report of `bootc upgrade --check` failing after a new install - this was using Anaconda with the legacy `ostreecontainer` verb that only knows about ostree. Hoist the image_exists_in_unified_storage() call (which ensures the bootc storage directory exists via get_ensure_imgstore()) above the opts.check branch so it runs for both --check and full upgrade paths. Relates: https://issues.redhat.com/browse/RHEL-153671 Assisted-by: OpenCode (Claude Opus 4) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
init-storage-earlier
branch
from
926bb52 to
3e09c50
Compare
Collaborator
🤔 |
Collaborator
Author
Collaborator
Collaborator
Author
|
None of the RPM jobs are currently blocking in the merge queue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a report of
bootc upgrade --checkfailing after a new install - this was using Anaconda with the legacyostreecontainerverb that only knows about ostree.Hoist the image_exists_in_unified_storage() call (which ensures the bootc storage directory exists via get_ensure_imgstore()) above the opts.check branch so it runs for both --check and full upgrade paths.
Relates: https://issues.redhat.com/browse/RHEL-153671
Assisted-by: OpenCode (Claude Opus 4)