Skip to content

Sort time dimension #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malmans2 merged 2 commits into from
Jan 19, 2026
Merged

Sort time dimension #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
575f24d
make sure time dim is sorted
malmans2 Jan 19, 2026
d45de88
cleanup
malmans2 Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions xarray_esgf/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,17 @@ def dataset_id_to_dict(dataset_id: str) -> dict[DATASET_ID_KEYS, str]:
return dict(zip(keys, dataset_id.split("."), strict=True))


def combine_datasets(datasets: list[Dataset]) -> Dataset:
obj = xr.combine_by_coords(
datasets,
join="exact",
combine_attrs="drop_conflicts",
)
if isinstance(obj, DataArray):
return obj.to_dataset()
return obj


@dataclasses.dataclass
class Client:
selection: dict[str, str | list[str]]
Expand Down Expand Up @@ -154,14 +165,7 @@ def _open_datasets(
if len(datasets) == 1:
(ds,) = datasets
else:
ds = xr.concat(
datasets,
dim="time",
data_vars="minimal",
coords="minimal",
compat="override",
combine_attrs="drop_conflicts",
)
ds = combine_datasets(datasets)
ds = ds.set_coords([
name
for name, da in ds.variables.items()
Expand Down Expand Up @@ -190,13 +194,7 @@ def open_dataset(
sel=sel or {},
)

obj = xr.combine_by_coords(
[ds.reset_coords() for ds in combined_datasets.values()],
join="exact",
combine_attrs="drop_conflicts",
)
if isinstance(obj, DataArray):
obj = obj.to_dataset()
obj = combine_datasets([ds.reset_coords() for ds in combined_datasets.values()])

coords: set[Hashable] = set()
for ds in combined_datasets.values():
Expand Down