legacy: move LegacyRepository, LegacyRemoteRepository, RepoObj1 into borg.legacy package, refs #9556#9559
Open
mr-raj12 wants to merge 2 commits intoborgbackup:masterfrom
Open
legacy: move LegacyRepository, LegacyRemoteRepository, RepoObj1 into borg.legacy package, refs #9556#9559mr-raj12 wants to merge 2 commits intoborgbackup:masterfrom
mr-raj12 wants to merge 2 commits intoborgbackup:masterfrom
Conversation
mr-raj12
force-pushed
the
legacy-package-phase1-2
branch
from
8d69edb to
c918e35
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9559 +/- ##
==========================================
- Coverage 83.36% 83.34% -0.03%
==========================================
Files 87 90 +3
Lines 15481 15494 +13
Branches 2325 2325
==========================================
+ Hits 12906 12913 +7
- Misses 1821 1828 +7
+ Partials 754 753 -1 ☔ View full report in Codecov by Sentry. |
Member
|
This is hard to review due to the code moves. Can you use an approach using git mv (when possible), commit, modify? |
Contributor
Author
|
Sure |
mr-raj12
force-pushed
the
legacy-package-phase1-2
branch
from
c918e35 to
472322e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Borg 1.x and 2.x code currently lives mixed in
src/borg/, so new 2.x code to remain constrained by legacy APIs and patterns.This PR creates
borg.legacyas a dedicated subpackage for all Borg 1.x compatibility code, isolating it from the 2.x codebase.New files:
src/borg/legacy/__init__.pysrc/borg/legacy/repository.py-LegacyRepository,LoggedIOsrc/borg/legacy/remote.py-LegacyRemoteRepositorysrc/borg/legacy/repoobj.py-RepoObj1Modified files:
legacyrepository.py,legacyremote.py,repoobj.pyare replaced with backward-compatible re-export stubsborg.legacy.*paths directlyBackward compatibility is fully preserved and all existing import paths continue to work via the stubs.
borg transfer --from-borg1remains unaffected.Refs #9556
Checklist