Skip to content

fix: Improve resource handling and error handling#2503

Open
Fikri-20 wants to merge 2 commits into
borgbase:masterfrom
Fikri-20:clean-critical-bugs
Open

fix: Improve resource handling and error handling#2503
Fikri-20 wants to merge 2 commits into
borgbase:masterfrom
Fikri-20:clean-critical-bugs

Conversation

@Fikri-20
Copy link
Copy Markdown

Fixes:

  • Temp file resource leaks on exceptions
  • Profile null pointer crashes
  • Error handling in archive template saving
  • File handle cleanup

- Use delete=False for temp files and proper cleanup on exception
- Add null checks for profile lookups using get_or_none()
- Improve error handling in archive template saving
- Use context manager for file reads
- Fix f-string formatting in scheduler debug message
@m3nu m3nu closed this Apr 28, 2026
@Fikri-20
Copy link
Copy Markdown
Author

Hi @m3nu ,
I appreciate your effort to review the PR, but should I know what’s the matter with the PR to be closed? What should I consider to make this PR mergable?

@m3nu
Copy link
Copy Markdown
Contributor

m3nu commented Apr 28, 2026

I'm closing all PRs since many were for the GSoC application process, which is now finished. If you think this PR adds value beyond that, I can review again if you want. Same for your other PR.

@Fikri-20
Copy link
Copy Markdown
Author

Yes I think my PRs solve important bugs in the app and worth resolving. please take a look.

@m3nu m3nu reopened this Apr 28, 2026
@borgbase borgbase deleted a comment from sonarqubecloud Bot Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants