Skip to content

Fix/broken table generation #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boriel merged 3 commits into from
Dec 15, 2024
Merged

Fix/broken table generation #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2f65ba
refact: refactorize typing
boriel Dec 14, 2024
63c9050
fix: fixes parsetab generation
boriel Dec 14, 2024
da9757c
test: add test to check parsetab building
boriel Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,22 @@ disable_error_code = [
"union-attr",
"var-annotated",
]
exclude = [
Copy link
Collaborator Author

@boriel boriel Dec 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartsanchez The entire src/ply/*.py should be excluded.

Fixing linting in these 3rd party files might introduce bugs and the lints are lost every time the library is updated (fortunately is a very stable one, so no need to update it very often).

'src/ply/.*\.py$'
]

[[tool.mypy.overrides]]
module = [
"src.ply.*",
]
follow_imports = "skip"

[tool.ruff]
line-length = 120
target-version = "py310"
exclude = [
"src/ply" # PLY, external 3rd party tool
]

[tool.ruff.lint]
select = [
Expand Down
8 changes: 4 additions & 4 deletions src/parsetab/tabs.dbm.bak
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'zxbpp', (0, 66990)
'asmparse', (67072, 233944)
'zxnext_asmparse', (301056, 259009)
'zxbparser', (560128, 641174)
'zxbpp', (0, 67003)
'asmparse', (67072, 233956)
'zxnext_asmparse', (301056, 259034)
'zxbparser', (560128, 641187)
Binary file modified src/parsetab/tabs.dbm.dat
View file
Open in desktop
Copy link
Collaborator Author

@boriel boriel Dec 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are binary (pickled / Python serialized) classes. The compiler takes like 10 seconds or more to generate these tables upon start up. With this cache the start time is < 1 sec.

Binary file not shown.
8 changes: 4 additions & 4 deletions src/parsetab/tabs.dbm.dir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
'zxbpp', (0, 66990)
'asmparse', (67072, 233944)
'zxnext_asmparse', (301056, 259009)
'zxbparser', (560128, 641174)
'zxbpp', (0, 67003)
'asmparse', (67072, 233956)
'zxnext_asmparse', (301056, 259034)
'zxbparser', (560128, 641187)
2 changes: 1 addition & 1 deletion src/ply/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Author: David Beazley (dave@dabeaz.com)
# https://github.com/dabeaz/ply

__version__ = "2022.10.27"
__version__ = '2022.10.27'
Loading
Loading