Skip to content

feat: add footer#16

Merged
adkah merged 2 commits into
masterfrom
ak-footer
May 13, 2026
Merged

feat: add footer#16
adkah merged 2 commits into
masterfrom
ak-footer

Conversation

@adkah
Copy link
Copy Markdown
Contributor

@adkah adkah commented May 13, 2026

Adds a footer component to the bottom of docs pages.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 13, 2026

Greptile Summary

This PR adds a footer.astro component containing five social-media icon links (X, GitHub, LinkedIn, YouTube, Discord) and wires it into the docs pages, home page, API pages, and the index page.

  • New component (footer.astro): purely icon-based footer with target=\"_blank\" rel=\"noreferrer\" on all external links; no visible text content today.
  • docs-page.astro: the outer <article> was wrapped in a <div data-pagefind-body> so the footer can sit alongside the article without being inside the semantic article element; footer is rendered in both the prose and non-prose branches.
  • [...slug].astro / index.astro / home-page.astro: footer added to each page's relevant rendering branch with appropriate layout constraints.

Confidence Score: 4/5

Safe to merge; the footer is purely presentational and the changes are additive with no impact on routing or data fetching.

The footer currently holds only SVG icons, so Pagefind won't index any text today. However it sits inside the data-pagefind-body boundary on every docs page, meaning any future text added to the footer will silently appear in search results without an additional code change.

footer.astro and docs-page.astro — both around the data-pagefind-body boundary.

Important Files Changed

Filename Overview
src/components/footer.astro New footer component with five social-media icon links; no text content, only SVG icons — safe from Pagefind pollution today but lacks data-pagefind-ignore for future-proofing.
src/components/docs-page.astro Footer added to both the prose and non-prose rendering branches; article wrapped in a div to allow Footer to sit alongside it. Footer sits inside data-pagefind-body in both branches.
src/pages/[...slug].astro Footer import added and rendered in the isApi branch only; non-API pages get their footer via DocsPage internally — no duplication.
src/pages/index.astro Footer added inside the prose article branch; non-prose branch does not get a footer, which appears intentional.
src/components/home-page.astro Footer added inside a constrained-width wrapper at the bottom of the home page — straightforward addition.
src/layouts/DocsLayout.astro Whitespace-only change (blank line added before the Props interface); no functional impact.

Comments Outside Diff (1)

  1. src/components/docs-page.astro, line 36-43 (link)

    P2 Footer inside data-pagefind-body scope

    In both branches, <Footer /> is rendered inside the element marked with data-pagefind-body. Pagefind indexes the text nodes within that boundary — the current footer only contains inline SVGs with aria-label attributes (no text nodes), so it won't pollute search results today. However, once any text content (e.g. copyright line, nav links) is added to the footer, it will silently appear in search indexes. Adding data-pagefind-ignore to the <footer> element in footer.astro would guard against this regardless of future content changes. The same concern applies to the useProse branch at line 87 and the equivalent placement in src/pages/index.astro.

Reviews (1): Last reviewed commit: "feat: add footer" | Re-trigger Greptile

Comment thread src/components/footer.astro Outdated
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@adkah adkah merged commit daaa7df into master May 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants