feat(popup-reply): add threaded annotation feature flag#735
Open
jackiejou wants to merge 1 commit intobox:masterfrom
Open
feat(popup-reply): add threaded annotation feature flag#735jackiejou wants to merge 1 commit intobox:masterfrom
jackiejou wants to merge 1 commit intobox:masterfrom
Conversation
- Add isThreadedAnnotation feature flag to conditionally render PopupReplyV2 - Refactor PopupReply Props to discriminated union (LegacyProps | ThreadedProps) - Migrate PopupReply tests from Enzyme to React Testing Library - Add @testing-library/react, @testing-library/dom, @testing-library/jest-dom deps - Add jest-setup.ts for global jest-dom matcher registration - Add test coverage for isThreadedAnnotation in PopupContainer and PopupLayer - Add tests for useEffect popper update and options referential integrity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isThreadedAnnotationfeature flag to conditionally renderPopupReplyV2stub componentPopupReplyProps to discriminated union (LegacyProps | ThreadedProps) for type-safe feature flag branchingPopupReplyandPopupLayertests from Enzyme to React Testing Library@testing-library/react,@testing-library/dom,@testing-library/jest-domdependencies with jest-setup configurationTest plan
tsc)isThreadedAnnotation: false(default) renders existing PopupReply UIisThreadedAnnotation: truerenders PopupReplyV2 placeholder