feat(content-preview): forward monitoring dimensions [PREVIEW-225]#4542
feat(content-preview): forward monitoring dimensions [PREVIEW-225]#4542ahorowitz123 wants to merge 2 commits intobox:masterfrom
Conversation
Accept accessPattern, previewMode, sharedLinkAuth as props on ContentPreview and pass them through to the underlying Preview library so emitted metric/error events are tagged for the monitoring dashboard. PREVIEW-225 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughContentPreview Props gain five optional monitoring fields ( ChangesPreview Monitoring Dimensions
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Accepts two new optional props on ContentPreview — prefetchStatus and preloadStatus — and threads them into previewOptions so box-content-preview can tag emitted load/error/outcome events. PREVIEW-225 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Accepts three new optional props on
<ContentPreview>—accessPattern,previewMode,sharedLinkAuth— and threads them intopreviewOptionsso the underlying Preview library can tag emittedpreview_metric/preview_errorevents for the monitoring dashboard.Why
Part of the Preview Performance Monitoring dashboard rollout under WEBAPP-53337. The dashboard needs to slice TTPL by access pattern, preview mode, and shared-link auth. Companion box-content-preview work (accepting + emitting these dimensions) landed in PREVIEW-224; host app call sites land in PREVIEW-226 and PREVIEW-227.
Ticket
PREVIEW-225
Test plan
preview.show()options when suppliedundefinedwhen props omitted🤖 Generated with Claude Code
Summary by CodeRabbit