feat(shared-link-modal): Deprecate shared-link-modal#4551
Merged
Conversation
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR completely removes the legacy ChangesDeprecate Old Shared-Link Modal
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/features/shared-link-settings-modal/SharedLinkSettingsModal.js (1)
25-28:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winJSDoc comment may need updating if constant values changed.
The JSDoc documents
accessLevelparameter as accepting string values'peopleWithTheLink','peopleInYourCompany', or'peopleInThisItem'. If the new constants (ANYONE_WITH_LINK,ANYONE_IN_COMPANY) have different string values than the old constants (e.g.,'anyoneWithTheLink'instead of'peopleWithTheLink'), this documentation will be incorrect.Update the JSDoc to reflect the actual values of the new constants once verified.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/features/shared-link-settings-modal/SharedLinkSettingsModal.js` around lines 25 - 28, Update the JSDoc for the accessLevel parameter in SharedLinkSettingsModal.js to match the actual string values used by the new constants (e.g., ANYONE_WITH_LINK, ANYONE_IN_COMPANY) instead of the old 'peopleWithTheLink'/'peopleInYourCompany'/'peopleInThisItem' names: locate the JSDoc above the function that accepts accessLevel (the function in SharedLinkSettingsModal.js) and replace the listed string examples with the real constant values (or reference the constants by name) after verifying the exact strings used by the ANYONE_WITH_LINK and ANYONE_IN_COMPANY constants.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/features/shared-link-settings-modal/SharedLinkSettingsModal.js`:
- Around line 25-28: Update the JSDoc for the accessLevel parameter in
SharedLinkSettingsModal.js to match the actual string values used by the new
constants (e.g., ANYONE_WITH_LINK, ANYONE_IN_COMPANY) instead of the old
'peopleWithTheLink'/'peopleInYourCompany'/'peopleInThisItem' names: locate the
JSDoc above the function that accepts accessLevel (the function in
SharedLinkSettingsModal.js) and replace the listed string examples with the real
constant values (or reference the constants by name) after verifying the exact
strings used by the ANYONE_WITH_LINK and ANYONE_IN_COMPANY constants.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f1db3ce4-2611-46bc-8329-7a03ab394252
⛔ Files ignored due to path filters (6)
i18n/en-US.propertiesis excluded by!i18n/**src/features/shared-link-modal/__tests__/__snapshots__/AccessLabel.test.js.snapis excluded by!**/*.snapsrc/features/shared-link-modal/__tests__/__snapshots__/AccessMenu.test.js.snapis excluded by!**/*.snapsrc/features/shared-link-modal/__tests__/__snapshots__/SharedLink.test.js.snapis excluded by!**/*.snapsrc/features/shared-link-modal/__tests__/__snapshots__/SharedLinkAccess.test.js.snapis excluded by!**/*.snapsrc/features/shared-link-modal/__tests__/__snapshots__/SharedLinkModal.test.js.snapis excluded by!**/*.snap
📒 Files selected for processing (31)
src/features/shared-link-modal/AccessDescription.jssrc/features/shared-link-modal/AccessLabel.jssrc/features/shared-link-modal/AccessMenu.jssrc/features/shared-link-modal/EmailSharedLink.jssrc/features/shared-link-modal/EmailSharedLink.scsssrc/features/shared-link-modal/PermissionMenu.jssrc/features/shared-link-modal/RemoveLinkConfirmModal.jssrc/features/shared-link-modal/SharedLink.jssrc/features/shared-link-modal/SharedLink.mdsrc/features/shared-link-modal/SharedLink.scsssrc/features/shared-link-modal/SharedLinkAccess.jssrc/features/shared-link-modal/SharedLinkModal.jssrc/features/shared-link-modal/SharedLinkModal.mdsrc/features/shared-link-modal/__tests__/AccessDescription.test.jssrc/features/shared-link-modal/__tests__/AccessLabel.test.jssrc/features/shared-link-modal/__tests__/AccessMenu.test.jssrc/features/shared-link-modal/__tests__/EmailSharedLink.test.jssrc/features/shared-link-modal/__tests__/PermissionMenu.test.jssrc/features/shared-link-modal/__tests__/RemoveLinkConfirmModal.test.jssrc/features/shared-link-modal/__tests__/SharedLink.test.jssrc/features/shared-link-modal/__tests__/SharedLinkAccess.test.jssrc/features/shared-link-modal/__tests__/SharedLinkModal.test.jssrc/features/shared-link-modal/constants.jssrc/features/shared-link-modal/index.jssrc/features/shared-link-modal/messages.jssrc/features/shared-link-modal/propTypes.jssrc/features/shared-link-modal/stories/SharedLink.stories.jssrc/features/shared-link-modal/stories/SharedLink.stories.mdsrc/features/shared-link-modal/stories/SharedLinkModal.stories.jssrc/features/shared-link-modal/stories/SharedLinkModal.stories.mdsrc/features/shared-link-settings-modal/SharedLinkSettingsModal.js
💤 Files with no reviewable changes (30)
- src/features/shared-link-modal/stories/SharedLinkModal.stories.md
- src/features/shared-link-modal/stories/SharedLink.stories.md
- src/features/shared-link-modal/constants.js
- src/features/shared-link-modal/index.js
- src/features/shared-link-modal/tests/PermissionMenu.test.js
- src/features/shared-link-modal/tests/RemoveLinkConfirmModal.test.js
- src/features/shared-link-modal/stories/SharedLink.stories.js
- src/features/shared-link-modal/SharedLinkModal.md
- src/features/shared-link-modal/SharedLink.md
- src/features/shared-link-modal/PermissionMenu.js
- src/features/shared-link-modal/tests/SharedLinkAccess.test.js
- src/features/shared-link-modal/tests/AccessLabel.test.js
- src/features/shared-link-modal/AccessLabel.js
- src/features/shared-link-modal/AccessDescription.js
- src/features/shared-link-modal/propTypes.js
- src/features/shared-link-modal/SharedLinkAccess.js
- src/features/shared-link-modal/RemoveLinkConfirmModal.js
- src/features/shared-link-modal/tests/SharedLink.test.js
- src/features/shared-link-modal/stories/SharedLinkModal.stories.js
- src/features/shared-link-modal/SharedLink.js
- src/features/shared-link-modal/messages.js
- src/features/shared-link-modal/tests/SharedLinkModal.test.js
- src/features/shared-link-modal/SharedLinkModal.js
- src/features/shared-link-modal/AccessMenu.js
- src/features/shared-link-modal/tests/AccessDescription.test.js
- src/features/shared-link-modal/EmailSharedLink.scss
- src/features/shared-link-modal/EmailSharedLink.js
- src/features/shared-link-modal/SharedLink.scss
- src/features/shared-link-modal/tests/AccessMenu.test.js
- src/features/shared-link-modal/tests/EmailSharedLink.test.js
jpan-box
approved these changes
May 12, 2026
tjiang-box
approved these changes
May 14, 2026
Contributor
Merge Queue Status
This pull request spent 1 minute 17 seconds in the queue, including 15 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Summary by CodeRabbit