-
Notifications
You must be signed in to change notification settings - Fork 15
feat(blocks): callback #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I need also to add: In this callback to fix the warnings, as I can see in this case they are just blocks https://github.com/search?q=repo%3Aunfoldadmin%2Fdjango-unfold%20usertools&type=code but I think that they are not loaded always just present if the template it will just calls them. |
|
ping |
|
I don't really understand the example, or the problem. The linked issue seems like it's talking about two things? One which I pointed out a bug that can be worked around, and then some other issue that was never explained? |
|
The bug you mentioned it was fixed, instead for the rest: If there are templates that are one inside others, there is this issue with that admin theme for Django. |
|
Sorry, but I can't understand what you mean. If you have a crash/error please copy paste it here. Your patch makes no sense to me as it is. |
|
I don't have anymore an installation with fastdev to show that error... |
Ref: #51
So in my investigation I discovered that the issue is because Unfold register a custom node,
CaptureNodeso it isn't possible to detect what is the real block as it isn't a Django one.With this code we are adding a new callback so the dev can implement a way to detect those blocks.
The readme include the code for Unfold theme as example.