#106: Added element <toc-text> as child element of <toc-entry>.#112
Open
PaulRambags wants to merge 7 commits intomasterfrom
Open
#106: Added element <toc-text> as child element of <toc-entry>.#112PaulRambags wants to merge 7 commits intomasterfrom
PaulRambags wants to merge 7 commits intomasterfrom
Conversation
PaulRambags
requested review from
BWestling,
bertfrees,
joeha480 and
kalaspuffar
Collaborator
|
Sorry haven't had time to look at this yet. Will do as soon as I can. |
bertfrees
reviewed
Oct 9, 2019
Collaborator
bertfrees
left a comment
bertfrees
left a comment
There was a problem hiding this comment.
I added three small inline comments.
The change looks good. It only makes sense to merge this when toc-text-resumed has been actually implemented though.
integrationtest/org/daisy/dotify/formatter/test/resource-files/dp2/toc-text-input.obfl
Outdated
Show resolved
Hide resolved
…RESUMED, improved description in toc-text test files.
Collaborator
|
Can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.