Optical Flow Update and Helmholtz Hodge Decomposition Enabling#311
Open
LeoNouvelle wants to merge 15 commits intobrainstorm-tools:masterfrom
Open
Optical Flow Update and Helmholtz Hodge Decomposition Enabling#311LeoNouvelle wants to merge 15 commits intobrainstorm-tools:masterfrom
LeoNouvelle wants to merge 15 commits intobrainstorm-tools:masterfrom
Conversation
martcous
reviewed
Jul 3, 2020
| end | ||
|
|
||
| % Uncomment following lines to display the unfilterd/original figure. | ||
| % if displayFlag |
Member
There was a problem hiding this comment.
This is already only executed when the displayFlag is set, why the need to uncomment this for debugging?
Member
|
Thank you Leo for your update. You are only modifying files related to the optical flow so this is a pretty safe merge. Were you planning on writing a documentation for your changes? This would greatly help us test this. Some minor comments right off the bat:
Great work! |
Member
|
@LeoNouvelle |
Collaborator
|
Xiaobo is working on the scientific/methods developments.
Will contribute to Brainstorm tools updates when ready.
Sylvain.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Here are the changes I commited in my pull request:
Minor code updates and corrections on:
Enabling Helmholtz-Hodge Decomposition:
Thanks,
Léo