add checkoutOption to GooglePayRequest by mrphilipandrews · Pull Request #1514 · braintree/braintree_android

mrphilipandrews · 2026-01-08T04:49:56Z

Summary of changes

add support checkoutOption param to GooglePayRequest

Checklist

Added a changelog entry
[ x] Relevant test coverage
[x ] Tested and confirmed payment flows affected by this change are functioning as expected

Authors

@fatlinesofcode

saralvasquez

Could you please include an entry in the CHANGELOG under the unreleased header detailing what changed in this PR? Look at other entries for an example

saralvasquez

Looks really good but I have a couple small comments

saralvasquez · 2026-02-11T23:01:40Z

                Settings.isGooglePayShippingAddressRequired(activity));
        googlePayRequest.setShippingAddressParameters(new GooglePayShippingAddressParameters(Settings.getGooglePayAllowedCountriesForShipping(requireContext())));
-
+        googlePayRequest.setCheckoutOption(GooglePayCheckoutOption.COMPLETE_IMMEDIATE_PURCHASE);


Suggested change

googlePayRequest.setCheckoutOption(GooglePayCheckoutOption.COMPLETE_IMMEDIATE_PURCHASE);

googlePayRequest.setCheckoutOption(GooglePayCheckoutOption.COMPLETE_IMMEDIATE_PURCHASE);

jaxdesmarais · 2026-03-11T14:39:28Z

@fatlinesofcode - are you able to address the feedback above? If so, we would be happy to re-review this PR. If we do not hear back we will go ahead and close this.

…raintree_android into googleplay-checkoutOption

mrphilipandrews · 2026-03-12T00:22:52Z

updated now @jaxdesmarais

saralvasquez

This semi colon is causing lint issues. Once it's removed this should be good to go in

saralvasquez

🎉

saralvasquez · 2026-04-06T21:42:52Z

Hi! Sorry this has been sitting for so long. We just got confirmation that this can be merged despite the security check permission issues. However, we don't have permissions on this fork to resolve some merge conflicts so could you please resolve those on your end? We'll go ahead and do one last check after that and then get this merged in

# Conflicts: # CHANGELOG.md # GooglePay/src/main/java/com/braintreepayments/api/googlepay/GooglePayRequest.kt # GooglePay/src/test/java/com/braintreepayments/api/googlepay/GooglePayRequestUnitTest.kt

mrphilipandrews · 2026-04-07T01:38:22Z

Hi! Sorry this has been sitting for so long. We just got confirmation that this can be merged despite the security check permission issues. However, we don't have permissions on this fork to resolve some merge conflicts so could you please resolve those on your end? We'll go ahead and do one last check after that and then get this merged in

thats done now

saralvasquez

This needs a couple small changes to the CHANGELOG entry

Co-authored-by: Sara Vasquez <98496950+saralvasquez@users.noreply.github.com> Signed-off-by: Philip Andrews <phil@frontside.com.au>

saralvasquez · 2026-04-10T18:01:29Z

There's more conflicts that we can't resolve from our side. Please resolve those. We'd also be happy to manage all of this if you change the permissions on this branch so that we can make commits

# Conflicts: # CHANGELOG.md

mrphilipandrews · 2026-04-13T04:35:09Z

hi @saralvasquez those conflicts are resolved now. i dont believe i can give you access to our organisation's branch

jaxdesmarais · 2026-04-13T14:16:16Z

+     */
+    DEFAULT("DEFAULT"),
+
+    CONTINUE_TO_REVIEW("CONTINUE_TO_REVIEW"),


This one is missing docstrings

jaxdesmarais · 2026-04-13T14:17:01Z

 * GooglePay
   * Add optional `DisplayItems` in GooglePay request
+   * Add support for `checkoutOption` to `GooglePayRequest` TransactionInfo params
+


Remove extra space

add checkoutOption to GooglePayRequest

d194e28

mrphilipandrews requested a review from a team as a code owner January 8, 2026 04:49

mrphilipandrews mentioned this pull request Jan 8, 2026

Googlepay checkoutOption #1513

Closed

update lint and unit tests for checkoutOption

5db5669

saperi22 approved these changes Feb 4, 2026

View reviewed changes

saralvasquez reviewed Feb 10, 2026

View reviewed changes

saralvasquez reviewed Feb 11, 2026

View reviewed changes

mrphilipandrews added 4 commits March 12, 2026 11:08

add checkoutOption to GooglePay test assertions

dfb373b

Merge branch 'braintree:main' into googleplay-checkoutOption

1ee0a54

Merge branch 'googleplay-checkoutOption' of github.com:Adore-Beauty/b…

c4c0094

…raintree_android into googleplay-checkoutOption

add checkoutOption to changelog

22828c8

saralvasquez reviewed Mar 12, 2026

View reviewed changes

Comment thread GooglePay/src/main/java/com/braintreepayments/api/googlepay/GooglePayCheckoutOption.kt Outdated

lint fix

7b48625

This comment was marked as spam.

Sign in to view

saralvasquez approved these changes Mar 30, 2026

View reviewed changes

Merge branch 'main' into googleplay-checkoutOption

e1a933d

# Conflicts: # CHANGELOG.md # GooglePay/src/main/java/com/braintreepayments/api/googlepay/GooglePayRequest.kt # GooglePay/src/test/java/com/braintreepayments/api/googlepay/GooglePayRequestUnitTest.kt

saralvasquez reviewed Apr 7, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

Comment thread CHANGELOG.md Outdated

Update CHANGELOG.md

e06ec41

Co-authored-by: Sara Vasquez <98496950+saralvasquez@users.noreply.github.com> Signed-off-by: Philip Andrews <phil@frontside.com.au>

saralvasquez reviewed Apr 9, 2026

View reviewed changes

Comment thread CHANGELOG.md

braintree deleted a comment from coursgranja01-del Apr 9, 2026

braintree deleted a comment from coursgranja91-hash Apr 9, 2026

mrphilipandrews and others added 2 commits April 10, 2026 09:34

Update CHANGELOG.md

83164d9

Co-authored-by: Sara Vasquez <98496950+saralvasquez@users.noreply.github.com> Signed-off-by: Philip Andrews <phil@frontside.com.au>

Update CHANGELOG.md

0964e79

Co-authored-by: Sara Vasquez <98496950+saralvasquez@users.noreply.github.com> Signed-off-by: Philip Andrews <phil@frontside.com.au>

Merge branch 'main' into googleplay-checkoutOption

3709318

# Conflicts: # CHANGELOG.md

jaxdesmarais reviewed Apr 13, 2026

View reviewed changes

mrphilipandrews added 2 commits April 14, 2026 11:07

update docs

dc98656

lint fix

8cf30de

mrphilipandrews requested a review from a team April 17, 2026 00:44

saralvasquez merged commit 319f4cd into braintree:main Apr 20, 2026
15 of 17 checks passed

	googlePayRequest.setCheckoutOption(GooglePayCheckoutOption.COMPLETE_IMMEDIATE_PURCHASE);
	googlePayRequest.setCheckoutOption(GooglePayCheckoutOption.COMPLETE_IMMEDIATE_PURCHASE);

Conversation

mrphilipandrews commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Checklist

Authors

Uh oh!

saralvasquez left a comment

Choose a reason for hiding this comment

Uh oh!

saralvasquez left a comment

Choose a reason for hiding this comment

Uh oh!

saralvasquez Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jaxdesmarais commented Mar 11, 2026

Uh oh!

mrphilipandrews commented Mar 12, 2026

Uh oh!

saralvasquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

saralvasquez left a comment

Choose a reason for hiding this comment

Uh oh!

saralvasquez commented Apr 6, 2026

Uh oh!

mrphilipandrews commented Apr 7, 2026

Uh oh!

saralvasquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saralvasquez commented Apr 10, 2026

Uh oh!

mrphilipandrews commented Apr 13, 2026

Uh oh!

jaxdesmarais Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

jaxdesmarais Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mrphilipandrews commented Jan 8, 2026 •

edited

Loading