Compose smart button by saperi22 · Pull Request #1531 · braintree/braintree_android

saperi22 · 2026-02-12T19:56:48Z

Summary of changes

Compose Smart button
Added analytics for presentment and selection.

Testing:

Tested AuthTab flow - works
Tested CCT flow - works
Tested app switch flow - works

~~Dependent on braintree/browser-switch-android#127 being merged in and released.~~

Checklist

Added a changelog entry
Relevant test coverage
Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

…fully. The flow is broken.

Works end to end and shows a successful response.

Use anticipated dependency version.

noguier · 2026-03-04T15:24:20Z

I tested this on my device and the flow works correctly, the only two things i noticed:

When I choose Payment Button Compose from the demo app menu , and the app switched to the new screen i see lingering "An error occurred: User did not complete payment flow"
The browser payment flow works great, but I was not able to app switch to PP app

PS:
Interestingly, I couldn't app switch from Payment Buttons or PayPal modules on this branch. But i am app switching correctly on main

Update this has been resolved.

Restrict view model and repository to library group. Make sure that handle return is called only after flow is launched.

noguier · 2026-03-04T20:44:55Z

i also wondering why the Instrumentation Tests are failing, I havent see this error before Caused by: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find com.braintreepayments.api:browser-switch:3.5.0.

saperi22 · 2026-03-04T20:48:59Z

i also wondering why the Instrumentation Tests are failing, I havent see this error before Caused by: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find com.braintreepayments.api:browser-switch:3.5.0.

Browser Switch 3.5.0 hasn't been published yet. I was using a 3.4.1-SNAPSHOT and didn't want to forget to change it. So, I made the change to 3.5.0. It is expected to fail until browser switch is published.

noguier · 2026-03-04T20:50:13Z

ahhh totally makes sense, thank you!

tdchow · 2026-03-09T16:53:12Z

+        }
+    }
+
+    suspend fun getPendingRequest(): String? {


Should we return a non null string here or throw an exception if the dataStore does not contain a pendingnRequest?

https://github.com/braintree/braintree_android/pull/1531/changes#diff-23d7463af226bd84a2ce92dfa837cbda03e749c683c45da489b4439978fb988aR161

I handle an empty pendingRequest here: https://github.com/braintree/braintree_android/pull/1531/changes#diff-23d7463af226bd84a2ce92dfa837cbda03e749c683c45da489b4439978fb988aR161

Non-null would be good, but I think I'd just have to return an empty string at the data store level and rest of the code would remain relatively the same. A few return types can be made non-null.

Not sure if we can throw an exception. We could log the exception and return a failure to the merchant.

I think the preferred error handling pattern is to throw exceptions and catch them at some level. I think at the ViewModel we could have a try/catch, then the view state could emit the error to the view.

I skipped the view model and am using the repository directly in the composable.

I am of the opinion that the repository should be able to send out an empty string.
I'm handling the exception at the view level where we know the state of the flow and we expect this value to be not empty.
Would you agree with my reasoning?

saralvasquez

Looks great! Tested on physical device and emulator and both worked as expected. Just a quick question. Did we want to set up a similar kind of layout for the different button color options as we did for the XML based buttons page?

saralvasquez · 2026-03-09T18:41:22Z

+@OptIn(ExperimentalCoroutinesApi::class)
+class PayPalPendingRequestRepositoryTest {
+
+    @get:Rule


Cool! That makes everything so much cleaner

saperi22 · 2026-03-09T19:49:28Z

Looks great! Tested on physical device and emulator and both worked as expected. Just a quick question. Did we want to set up a similar kind of layout for the different button color options as we did for the XML based buttons page?

I have a different ticket to setup the demo app. This one is to make sure the flow works.
I don't want to bloat the PR and sit on it forever.

* Paypal buttons compose (#1528) * WIP: add dependencies and PayPalButton * paypal button * Add logo offset. * cleanup * cleanup * Working circular progress indicator * Add corner shape * WIP: interaction states * focus indicator * make linter gods happy * linter * linter * use colorResource * update focus padding to use a resource * remove spacers from preview * Compose smart button (#1531) * Compiling demo of PayPal smart button on Compose. Doesn't run successfully. The flow is broken. * Reorder buttons in demo app * refactor file name * fix button size * fix button size in demo * Skip modular and store pendingRequest state within composable. Works end to end and shows a successful response. * hoist style to parent composable * update demo app * remove unused classes * linter' * remember PayPalLauncher and PayPalClient beyond recomposition * Address PR comments * surface failure scenarios to host app * persist pending request to data store * linter * Cleanup. Use anticipated dependency version. * Use scope properly * linter fixes * Address PR comments. Restrict view model and repository to library group. Make sure that handle return is called only after flow is launched. * make function private * add tests * Add analytics events for paypal compose button flow * fix CI * fix test. * remove viewmodel to simplify flow * linter * add kdoc on composable * Address PR comments * add jvmoverloads * make repository return a non null value for pending request * Venmo compose button (#1541) * Compiling demo of PayPal smart button on Compose. Doesn't run successfully. The flow is broken. * Reorder buttons in demo app * refactor file name * fix button size * fix button size in demo * Skip modular and store pendingRequest state within composable. Works end to end and shows a successful response. * hoist style to parent composable * update demo app * remove unused classes * linter' * remember PayPalLauncher and PayPalClient beyond recomposition * Address PR comments * surface failure scenarios to host app * persist pending request to data store * linter * Cleanup. Use anticipated dependency version. * Use scope properly * linter fixes * Address PR comments. Restrict view model and repository to library group. Make sure that handle return is called only after flow is launched. * make function private * add tests * Add analytics events for paypal compose button flow * fix CI * fix test. * remove viewmodel to simplify flow * linter * add kdoc on composable * Address PR comments * Venmo buttons compose UI * Update analytics * Venmo compose button * update demo app * rename options * update checkout values * consolidate extension functions * refactoring * refactor * add kdoc * Update repository to take in a moduleName parameter and update tests * rename file * Add exception message * update venmo button content description * update to 3.5.1 of browser switch * rename buttons * update changelog * Making ActivityResultRegistry a required parameter for Venmo/PayPal Launcher constructors. This preserves backwards compatibility. * Renaming VenmoSmartButton to VenmoButton * Add Changelog entry * linter fix * Update UIComponents/src/main/java/com/braintreepayments/api/uicomponents/compose/PayPalButton.kt Co-authored-by: Sara Vasquez <98496950+saralvasquez@users.noreply.github.com> * Update UIComponents/src/main/java/com/braintreepayments/api/uicomponents/compose/VenmoButton.kt Co-authored-by: Sara Vasquez <98496950+saralvasquez@users.noreply.github.com> * update changelog.md * update demo app * change requireNotNull to if condition * Sends merchants a Failure result when compose is not started from a ComponentActivity * linter * address PR comments * enable button after a failure * enable button after a failure * fix critical issue where flow freezes when activity is null * remove setting intent to null, need documentation for merchant to that on their end --------- Co-authored-by: Sara Vasquez <98496950+saralvasquez@users.noreply.github.com>

saperi22 added 10 commits February 10, 2026 12:05

Compiling demo of PayPal smart button on Compose. Doesn't run success…

ca23e1f

…fully. The flow is broken.

Reorder buttons in demo app

8c859e7

refactor file name

f59f019

fix button size

f8d8265

fix button size in demo

6cd26f3

Skip modular and store pendingRequest state within composable.

76a263b

Works end to end and shows a successful response.

hoist style to parent composable

2fa41a7

update demo app

c8356ff

remove unused classes

c17424d

linter'

92391ae

tdchow reviewed Feb 23, 2026

View reviewed changes

saperi22 added 5 commits February 23, 2026 14:37

remember PayPalLauncher and PayPalClient beyond recomposition

c986b62

Address PR comments

58a4091

surface failure scenarios to host app

6becf70

persist pending request to data store

3c20dd1

linter

934b312

saperi22 added the do not merge label Feb 25, 2026

saperi22 added 3 commits February 25, 2026 16:55

Cleanup.

1545cc0

Use anticipated dependency version.

Use scope properly

e41b1fe

linter fixes

c5fdd9a

saperi22 marked this pull request as ready for review March 3, 2026 19:15

saperi22 requested a review from a team as a code owner March 3, 2026 19:15

noguier reviewed Mar 4, 2026

View reviewed changes

Comment thread ...src/main/java/com/braintreepayments/api/uicomponents/compose/PayPalComposeButtonViewModel.kt Outdated

Comment thread UIComponents/src/main/java/com/braintreepayments/api/uicomponents/compose/PayPalSmartButton.kt Outdated

noguier reviewed Mar 4, 2026

View reviewed changes

Comment thread UIComponents/src/main/java/com/braintreepayments/api/uicomponents/compose/PayPalSmartButton.kt Outdated

saperi22 added 2 commits March 4, 2026 12:14

Address PR comments.

dd12bda

Restrict view model and repository to library group. Make sure that handle return is called only after flow is launched.

make function private

dca8f06

add tests

bccc828

saperi22 removed the do not merge label Mar 5, 2026

saperi22 added 2 commits March 5, 2026 14:25

Add analytics events for paypal compose button flow

2ffc34c

fix CI

a18f95c

noguier approved these changes Mar 6, 2026

View reviewed changes

Comment thread UIComponents/src/main/java/com/braintreepayments/api/uicomponents/UIComponentsAnalytics.kt Outdated

saperi22 added 3 commits March 6, 2026 12:49

fix test.

698a82c

remove viewmodel to simplify flow

b3dbb06

linter

0faa265

jaxdesmarais reviewed Mar 9, 2026

View reviewed changes

Comment thread UIComponents/src/main/java/com/braintreepayments/api/uicomponents/UIComponentsAnalytics.kt Outdated

tdchow reviewed Mar 9, 2026

View reviewed changes

saperi22 added 2 commits March 9, 2026 10:29

add kdoc on composable

f81d931

Address PR comments

36df6ee

saralvasquez approved these changes Mar 9, 2026

View reviewed changes

saperi22 added 2 commits March 9, 2026 12:51

add jvmoverloads

520659e

make repository return a non null value for pending request

4bc9810

saperi22 merged commit daf8428 into ui-components-compose-support Mar 11, 2026
13 of 14 checks passed

saperi22 deleted the compose-smart-button branch March 11, 2026 18:21

Conversation

saperi22 commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Checklist

Authors

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noguier commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noguier commented Mar 4, 2026

Uh oh!

saperi22 commented Mar 4, 2026

Uh oh!

noguier commented Mar 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tdchow Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

saperi22 Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

saperi22 Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

tdchow Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

saperi22 Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

saperi22 Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saralvasquez left a comment

Choose a reason for hiding this comment

Uh oh!

saralvasquez Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

saperi22 commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

saperi22 commented Feb 12, 2026 •

edited

Loading

noguier commented Mar 4, 2026 •

edited

Loading