Skip to content

fix bitmap plot screen location #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevesims wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix bitmap plot screen location #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01dac9b
fix bitmap plot screen location
stevesims Dec 3, 2023
a20b2fc
bitmap fixes
stevesims Dec 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion video/graphics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ void plotCopyMove(uint8_t mode) {
// Plot bitmap
//
void plotBitmap() {
drawBitmap(p1.X, p1.Y);
drawBitmap(p1.X, p1.Y, true);
}

// Character plot
Expand Down
4 changes: 2 additions & 2 deletions video/sprites.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ inline uint16_t getCurrentBitmapId() {
return currentBitmap;
}

void drawBitmap(uint16_t x, uint16_t y) {
void drawBitmap(uint16_t x, uint16_t y, bool compensateHeight = false) {
auto bitmap = getBitmap();
if (bitmap) {
canvas->drawBitmap(x, y, bitmap.get());
canvas->drawBitmap(x, (compensateHeight && logicalCoords) ? y - bitmap->height : y, bitmap.get());
} else {
debug_log("drawBitmap: bitmap %d not found\n\r", currentBitmap);
}
Expand Down
2 changes: 1 addition & 1 deletion video/vdu_buffered.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ void VDUStreamProcessor::bufferClear(uint16_t bufferId) {
// This is used for creating buffers to redirect output to
//
std::shared_ptr<WritableBufferStream> VDUStreamProcessor::bufferCreate(uint16_t bufferId, uint32_t size) {
if (bufferId == 0 || bufferId == 65535) {
if (bufferId == 65535) {
debug_log("bufferCreate: bufferId %d is reserved\n\r", bufferId);
return nullptr;
}
Expand Down