Allow developer to control FPM Timeout via Environment Variable #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different approach for #770. The question remains the same: Should bref support APIs that take longer than 30 seconds via ALB?
The environment variable approach has it's downsides of being weird. During Lambda configuration, I'll have to setup my timeout on Lambda Timeout and set it up again on a BREF environment variable. But it seems less error-prone and simpler to document and maintain. If AWS ever decides to offer an automatic environment variable with the timeout, it's an easy migration path forward.
This approach has no mixing of layers or weird overwrites, but it does come with an environment variable maintenance cost.