Added Lambda and API Gateway request IDs to Cloudwatch logs when there's a PHP-FPM issue #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
reviewed
Feb 18, 2021
Member
mnapoli
left a comment
mnapoli
left a comment
There was a problem hiding this comment.
Looks good to me, added some comments
Co-authored-by: Matthieu Napoli <matthieu@mnapoli.fr>
GrahamCampbell
suggested changes
Mar 27, 2021
| */ | ||
| public function handleRequest(HttpRequestEvent $event, Context $context): HttpResponse | ||
| { | ||
| $this->lambdaRequestId = $context->getAwsRequestId(); |
Contributor
There was a problem hiding this comment.
Why are we mutating the handler state?
Member
There was a problem hiding this comment.
Yes, this is exactly where I stumbled when working on this locally.
I don't really want to store state in the class, but then that means passing it everywhere.
This led me to realize that in most cases there is no context associated to the log lines, since we boot PHP-FPM before any request comes in.
In the end, I'm not 100% sure about the approach, and #895 may be able to remove the source issue.
Contributor
There was a problem hiding this comment.
Yeh, I agree #895 or something like it, is really the best option here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.