ec: make P384 code a little bit more generic #1883
Open
+352
−330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkrasnov
force-pushed
the
vlad/generic_p384
branch
2 times, most recently
from
cd5bb02 to
cb22a81
Compare
This change makes it easier to reuse the P384 code which is quite generic already. No algorithmic changes are made, only some code is shuffled around. This prepares the ground for P521 implementation.
vkrasnov
force-pushed
the
vlad/generic_p384
branch
from
cb22a81 to
fcf5cd6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
- Coverage 96.02% 96.01% -0.01%
==========================================
Files 136 136
Lines 20776 20775 -1
Branches 226 228 +2
==========================================
- Hits 19950 19947 -3
Misses 792 792
- Partials 34 36 +2 ☔ View full report in Codecov by Sentry. |
|
Hello! Has there been any progress on this? It seems to be a blocker for #1631 which means rustls with ring simply does not work with P521. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it easier to reuse the P384 code which is quite generic already. No algorithmic changes are made, only some code is shuffled around. This prepares the ground for P521 implementation.