rsa: Allocate public key on the stack in one-shot verification. #2736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move implementation details `Inner` and `ValidatedInput` to a `base` submodulue, and rename `Inner` to `base::PublicKey`. This facilitates future refactorings to eliminate some wasteful allocations.
These comments make more sense in the new location. They should have been moved in an earlier refactoring.
briansmith
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2736 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 199 201 +2
Lines 20413 20475 +62
Branches 526 526
=======================================
+ Hits 19721 19782 +61
Misses 577 577
- Partials 115 116 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
briansmith
force-pushed
the
b/splitter-2
branch
from
8eb0c61 to
fc36a41
Compare
briansmith
force-pushed
the
b/splitter-2
branch
from
fc36a41 to
629dda9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.