Imu fix chart orientation#416
Closed
TakKanekoGit wants to merge 7 commits into
Closed
Conversation
added 4 commits
April 30, 2026 22:27
… IMU dead-reckoning if plate-solve fails.
…dinate chart display in the Southern hemisphere
Owner
|
Hi @TakKanekoGit thanks for this great double-pr update for the chart screen. I merged the later one firstand ended up with a conflict on this earlier one 😅 I think I've fixed it up and it seems to run fine, but before I merge this to main would you take a quick scan of integrator.py to make sure I didn't make a more subtle mistake? |
Contributor
Author
|
Hi @brickbots -- Thank you! Actually, this PR (#416) is a direct descendent of the PR you merged in (#417) so all the functionalities from this PR is already in Maybe the easiest option is to abandon this PR? If you're ok with that, I will remove it. |
Owner
|
Hi Hi! Yes, that sounds great, if #417 does the job then I'll close this. Thanks again for this great update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes chart display with the quaternion version of the integrator.
Fixed by rotating the chart by
-parallactic_anglerather thanroll.When
mount_typeis alt/az, it will correctly display the chart in horizontal coordinates. If themount_typeis equatorial, it will display the chart in equatorial coordinates (north-up in norther hemisphere and south-up in southern hemisphere). If location or time is not available from the GPS, the chart display will default to equatorial coordinates (north-up).Sky tested (f53401a) 1 May 2026 in the northern hemisphere.