Refactor astro coords#420
Merged
Merged
Conversation
added 11 commits
May 12, 2026 20:01
mrosseel
added a commit
to mrosseel/PiFinder
that referenced
this pull request
May 16, 2026
Upstream's astro_coords refactor (brickbots#420) moved RaDecRoll from pointing_model/astro_coords.py to types/coordinates.py and reworked the API: constructor now takes (ra, dec, roll, deg=...) and replaces set_from_deg/get_deg with set(...) and get(deg=True). Resolution: - integrator.py: kept HEAD; dropped duplicate helpers (now in pointing.py) - pointing.py: updated import path and ported all RaDecRoll calls to the new API (set_from_deg/get_deg → constructor / get(deg=True)) - integrator_classic.py: accepted upstream deletion (brickbots#421 dropped classic integrator); telemetry's only change was a trivial **kwargs signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor refactoring of the quaternion-based pointing model:
PiFinder.pointing_model.astro_coords.RaDecRolltoPiFinder.types.coordinates.RaDecRoll.RaDecandAltAzBench-tested in test mode (7f18603)