represent complex literals as expressions #6522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes complex literals in the sem tree and DAG to always be represented by expressions. To enforce this, we changed sem.LiteralExpr and dag.LiteralExpr to PrimitiveExpr and created sem.NewLiteral() to handle all creations of complex literal values. NewLiteral() can also be used on primitive types as it creates a PrimitiveExpr for primitive types and an expression for complex literals. This refactoring exposed the fact that complex literals could be handled by the bsup bufferfilter and the pruning logic in the optimizer. With these changes, bufferfilter and pruning is now limited to primitive types. We also fixed super.NewTypeValue which was using the wrong type ID.
mattnibs
approved these changes
Jan 13, 2026
mattnibs
reviewed
Jan 13, 2026
nwt
approved these changes
Jan 14, 2026
| func NewIP(a netip.Addr) Value { return NewValue(TypeIP, EncodeIP(a)) } | ||
| func NewNet(p netip.Prefix) Value { return NewValue(TypeNet, EncodeNet(p)) } | ||
| func NewTypeValue(t Type) Value { return NewValue(TypeNet, EncodeTypeValue(t)) } | ||
| func NewTypeValue(t Type) Value { return NewValue(TypeType, EncodeTypeValue(t)) } |
Member
There was a problem hiding this comment.
Yikes. This bug's been here since I added NewTypeValue in January 2023.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes complex literals in the sem tree and DAG to always be represented by expressions. To enforce this, we changed sem.LiteralExpr and dag.LiteralExpr to PrimitiveExpr and created sem.NewLiteral() to handle all creations of complex literal values. NewLiteral() can also be used on primitive types as it creates a PrimitiveExpr for primitive types and an expression for complex literals.
This refactoring exposed the fact that complex literals could be handled by the bsup bufferfilter and the pruning logic in the optimizer. With these changes, bufferfilter and pruning is now limited to primitive types.
We also fixed super.NewTypeValue which was using the wrong type ID.