Remove cache for HasError function #6530
Open
+32
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
force-pushed
the
has_error-rm-cache
branch
from
fb087f7 to
210ec8a
Compare
mattnibs
force-pushed
the
has_error-rm-cache
branch
from
210ec8a to
7309eeb
Compare
This commit removes the caching logic from the sequential runtime implementation of the HasError function. There was a bug in the current implementation where unions values that had an error type but were not errors themselves would report the entire union type as a cacheable non-error then subsequent error values of that union would get false reported as not having an error. This caching behavior could be fixed with additional logic but since we are not so interested in performance in the sequential runtime remove the caching and simplify the logic. Fixes #6199
mattnibs
force-pushed
the
has_error-rm-cache
branch
from
7309eeb to
6cb03ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the caching logic from the sequential runtime implementation of the HasError function. There was a bug in the current implementation where unions values that had an error type but were not errors themselves would report the entire union type as a cacheable non-error then subsequent error values of that union would get false reported as not having an error. This caching behavior could be fixed with additional logic but since we are not so interested in performance in the sequential runtime remove the caching and simplify the logic.
Fixes #6199